* [PATCH] sim: check pins even if language checks fails
@ 2010-08-25 13:44 Pekka.Pessi
2010-08-25 16:48 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Pekka.Pessi @ 2010-08-25 13:44 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
From: Pekka Pessi <Pekka.Pessi@nokia.com>
---
src/sim.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/sim.c b/src/sim.c
index a450b30..be2793b 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -1373,7 +1373,7 @@ skip_efpl:
}
if (sim->language_prefs == NULL)
- return;
+ goto done;
ofono_dbus_signal_array_property_changed(conn, path,
OFONO_SIM_MANAGER_INTERFACE,
@@ -1381,6 +1381,7 @@ skip_efpl:
DBUS_TYPE_STRING,
&sim->language_prefs);
+done:
sim_pin_check(sim);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sim: check pins even if language checks fails
2010-08-25 13:44 [PATCH] sim: check pins even if language checks fails Pekka.Pessi
@ 2010-08-25 16:48 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-08-25 16:48 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
Hi Pekka,
On 08/25/2010 08:44 AM, Pekka.Pessi(a)nokia.com wrote:
> From: Pekka Pessi <Pekka.Pessi@nokia.com>
>
> ---
> src/sim.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/sim.c b/src/sim.c
> index a450b30..be2793b 100644
> --- a/src/sim.c
> +++ b/src/sim.c
> @@ -1373,7 +1373,7 @@ skip_efpl:
> }
>
> if (sim->language_prefs == NULL)
> - return;
> + goto done;
>
> ofono_dbus_signal_array_property_changed(conn, path,
> OFONO_SIM_MANAGER_INTERFACE,
> @@ -1381,6 +1381,7 @@ skip_efpl:
> DBUS_TYPE_STRING,
> &sim->language_prefs);
>
> +done:
> sim_pin_check(sim);
> }
>
Good catch, I ended up solving it slightly differently.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-25 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-25 13:44 [PATCH] sim: check pins even if language checks fails Pekka.Pessi
2010-08-25 16:48 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.