* [PATCH] simfilesystem: correct sw2 response for binary read
@ 2010-08-18 11:14 Kristen Carlson Accardi
2010-08-25 17:46 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Kristen Carlson Accardi @ 2010-08-18 11:14 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
according to spec, sw2 should be the number of bytes read, which
is just length.
---
src/simfilesystem.cpp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/simfilesystem.cpp b/src/simfilesystem.cpp
index d193328..6e05039 100644
--- a/src/simfilesystem.cpp
+++ b/src/simfilesystem.cpp
@@ -226,7 +226,7 @@ void SimFileSystem::crsm( const QString& args )
sw2 = 0x02;
} else if ( length ) {
sw1 = 0x9f;
- sw2 = length - offset;
+ sw2 = length;
response =
QAtUtils::toHex( contents.mid( offset, length ) );
} else {
--
1.7.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] simfilesystem: correct sw2 response for binary read
2010-08-18 11:14 [PATCH] simfilesystem: correct sw2 response for binary read Kristen Carlson Accardi
@ 2010-08-25 17:46 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-08-25 17:46 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
Hi Kristen,
On 08/18/2010 06:14 AM, Kristen Carlson Accardi wrote:
> according to spec, sw2 should be the number of bytes read, which
> is just length.
> ---
Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-25 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-18 11:14 [PATCH] simfilesystem: correct sw2 response for binary read Kristen Carlson Accardi
2010-08-25 17:46 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.