From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Haicheng Li <haicheng.li@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [BUGFIX][PATCH 1/2] x86, mem: separate x86_64 vmalloc_sync_all() into separate functions
Date: Wed, 25 Aug 2010 12:14:40 -0700 [thread overview]
Message-ID: <4C756BA0.2090700@zytor.com> (raw)
In-Reply-To: <87r5hni19y.fsf@basil.nowhere.org>
On 08/25/2010 12:45 AM, Andi Kleen wrote:
> Haicheng Li <haicheng.li@linux.intel.com> writes:
>
>> hello,
>>
>> Resend these two patches for bug fixing:
>>
>> The bug is that when memory hotplug-adding happens for a large enough area that a new PGD entry is
>> needed for the direct mapping, the PGDs of other processes would not get updated. This leads to some
>> CPUs oopsing when they have to access the unmapped areas, e.g. onlining CPUs on the new added node.
>
> The patches look good to me. Can we please move forward with this?
>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
>
The patches are mangled so they don't apply even with patch -l --
Haicheng, could you send me another copy, as an attachment if necessary?
-hpa
WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Haicheng Li <haicheng.li@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"ak@linux.intel.com" <ak@linux.intel.com>,
Wu Fengguang <fengguang.wu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [BUGFIX][PATCH 1/2] x86, mem: separate x86_64 vmalloc_sync_all() into separate functions
Date: Wed, 25 Aug 2010 12:14:40 -0700 [thread overview]
Message-ID: <4C756BA0.2090700@zytor.com> (raw)
In-Reply-To: <87r5hni19y.fsf@basil.nowhere.org>
On 08/25/2010 12:45 AM, Andi Kleen wrote:
> Haicheng Li <haicheng.li@linux.intel.com> writes:
>
>> hello,
>>
>> Resend these two patches for bug fixing:
>>
>> The bug is that when memory hotplug-adding happens for a large enough area that a new PGD entry is
>> needed for the direct mapping, the PGDs of other processes would not get updated. This leads to some
>> CPUs oopsing when they have to access the unmapped areas, e.g. onlining CPUs on the new added node.
>
> The patches look good to me. Can we please move forward with this?
>
> Reviewed-by: Andi Kleen <ak@linux.intel.com>
>
The patches are mangled so they don't apply even with patch -l --
Haicheng, could you send me another copy, as an attachment if necessary?
-hpa
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-25 19:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 9:45 [BUGFIX][PATCH 1/2] x86, mem: separate x86_64 vmalloc_sync_all() into separate functions Haicheng Li
2010-08-20 9:45 ` Haicheng Li
2010-08-20 9:50 ` [BUGFIX][PATCH 2/2] x86, mem: update all PGDs for direct mapping and vmemmap mapping changes on 64bit Haicheng Li
2010-08-20 9:50 ` Haicheng Li
2010-08-25 21:37 ` [tip:x86/mm] x86-64, mem: Update all PGDs for direct mapping and vmemmap mapping changes tip-bot for Haicheng Li
2010-08-26 21:34 ` tip-bot for Haicheng Li
2010-08-25 7:45 ` [BUGFIX][PATCH 1/2] x86, mem: separate x86_64 vmalloc_sync_all() into separate functions Andi Kleen
2010-08-25 7:45 ` Andi Kleen
2010-08-25 19:14 ` H. Peter Anvin [this message]
2010-08-25 19:14 ` H. Peter Anvin
2010-08-25 21:36 ` H. Peter Anvin
2010-08-25 21:36 ` H. Peter Anvin
2010-08-25 21:37 ` [tip:x86/mm] x86, mm: Separate " tip-bot for Haicheng Li
2010-08-26 21:33 ` tip-bot for Haicheng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C756BA0.2090700@zytor.com \
--to=hpa@zytor.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.