* [PATCH] simutil: Fix compilation with gcc 4.3.2
@ 2010-08-26 12:36 Andrzej Zaborowski
2010-08-26 23:45 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Andrzej Zaborowski @ 2010-08-26 12:36 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
This gcc version gives two signed / unsigned comparison warnings.
---
src/simutil.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/simutil.c b/src/simutil.c
index 2d0764c..ac054ae 100644
--- a/src/simutil.c
+++ b/src/simutil.c
@@ -1420,7 +1420,7 @@ gboolean sim_parse_2g_get_response(const unsigned char *response, int len,
gboolean sim_ust_is_available(unsigned char *efust, unsigned char len,
enum sim_ust_service index)
{
- if (index >= len * 8)
+ if (index >= len * 8u)
return FALSE;
return (efust[index / 8] >> (index % 8)) & 1;
@@ -1429,7 +1429,7 @@ gboolean sim_ust_is_available(unsigned char *efust, unsigned char len,
gboolean sim_est_is_active(unsigned char *efest, unsigned char len,
enum sim_est_service index)
{
- if (index >= len * 8)
+ if (index >= len * 8u)
return FALSE;
return (efest[index / 8] >> (index % 8)) & 1;
--
1.7.1.86.g0e460.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] simutil: Fix compilation with gcc 4.3.2
2010-08-26 12:36 [PATCH] simutil: Fix compilation with gcc 4.3.2 Andrzej Zaborowski
@ 2010-08-26 23:45 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-08-26 23:45 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
Hi Andrew,
On 08/26/2010 07:36 AM, Andrzej Zaborowski wrote:
> This gcc version gives two signed / unsigned comparison warnings.
> ---
> src/simutil.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Patch has been applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-26 23:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-26 12:36 [PATCH] simutil: Fix compilation with gcc 4.3.2 Andrzej Zaborowski
2010-08-26 23:45 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.