Re: [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX

[Avi Kivity <avi@redhat.com>]

  On 08/27/2010 12:41 PM, Jes Sorensen wrote:
> On 08/27/10 11:21, Avi Kivity wrote:
>>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>>> index cf56462..8e95371 100644
>>> --- a/arch/x86/kvm/vmx.c
>>> +++ b/arch/x86/kvm/vmx.c
>>> @@ -2888,6 +2888,8 @@ static void vmx_inject_nmi(struct kvm_vcpu *vcpu)
>>>            kvm_rip_write(vcpu, vmx->rmode.irq.rip - 1);
>>>            return;
>>>        }
>>> +    vmcs_write32(GUEST_INTERRUPTIBILITY_INFO,
>>> +            vmcs_read32(GUEST_INTERRUPTIBILITY_INFO)&
>>> ~GUEST_INTR_STATE_STI);
>> vmcs_clear_bits() is a nicer way of doing this.
>>
> Ok, try v2 that I just posted - and forgot to add v2 in the Subject line
> to - sorry.
>

Well, in light of Jan's comment re sti; hlt being clobbered by this, we 
should think about requesting an interrupt window instead...

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.