[PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Steffen Sledz]

Signed-off-by: Steffen Sledz <sledz@dresearch.de>
---
 recipes/rsyslog/rsyslog.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/recipes/rsyslog/rsyslog.inc b/recipes/rsyslog/rsyslog.inc
index a3bd125..e66e971 100644
--- a/recipes/rsyslog/rsyslog.inc
+++ b/recipes/rsyslog/rsyslog.inc
@@ -2,7 +2,7 @@ DESCRIPTION = "Rsyslog is an enhanced multi-threaded syslogd"
 DEPENDS = "zlib"
 HOMEPAGE = "http://www.rsyslog.com/"
 LICENSE = "GPLv3"
-INC_PR = "r1"
+INC_PR = "r2"
 
 SRC_URI = "http://www.rsyslog.com/files/download/rsyslog/${PN}-${PV}.tar.gz \
           file://rsyslog.conf \
@@ -60,3 +60,4 @@ pkg_postrm_${PN} () {
 CONFFILES_${PN} = "${sysconfdir}/rsyslog.conf"
 
 INITSCRIPT_NAME = "syslog"
+INITSCRIPT_PARAMS = "start 20 2 3 4 5 . stop 90 0 1 6 ."
-- 
1.6.4.2

Re: [PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Steffen Sledz]

Am 27.08.2010 15:48, schrieb Steffen Sledz:
> ...
> +INITSCRIPT_PARAMS = "start 20 2 3 4 5 . stop 90 0 1 6 ."

I just wanted to ask if there are any objections (e.g. a policy on using start/stop order 'levels') in using 'stop 90' here.

Steffen

Re: [PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Khem Raj]

On Fri, Aug 27, 2010 at 7:05 AM, Steffen Sledz <sledz@dresearch.de> wrote:
> Am 27.08.2010 15:48, schrieb Steffen Sledz:
>> ...
>> +INITSCRIPT_PARAMS = "start 20 2 3 4 5 . stop 90 0 1 6 ."
>
> I just wanted to ask if there are any objections (e.g. a policy on using start/stop order 'levels') in using 'stop 90' here.
>

I guess its distro maintainers call isnt it ? in that case you should
just add distro specific overrides for ones who want
it unless its a thing that all distros want.

> Steffen
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Steffen Sledz]

Am 28.08.2010 01:34, schrieb Khem Raj:
>>> +INITSCRIPT_PARAMS = "start 20 2 3 4 5 . stop 90 0 1 6 ."
>>
>> I just wanted to ask if there are any objections (e.g. a policy on
>> using start/stop order 'levels') in using 'stop 90' here.
>>
> 
> I guess its distro maintainers call isnt it ?

I'm not sure if it is. That's why i asked for policies about this. ;-)

Steffen

Re: [PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Phil Blundell]

On Sun, 2010-08-29 at 13:39 +0200, Steffen Sledz wrote:
> Am 28.08.2010 01:34, schrieb Khem Raj:
> >>> +INITSCRIPT_PARAMS = "start 20 2 3 4 5 . stop 90 0 1 6 ."
> >>
> >> I just wanted to ask if there are any objections (e.g. a policy on
> >> using start/stop order 'levels') in using 'stop 90' here.
> >>
> > 
> > I guess its distro maintainers call isnt it ?
> 
> I'm not sure if it is. That's why i asked for policies about this. ;-)

Yes, the DISTRO maintainers would have the final say about start/stop
levels (and, indeed, whether to use sysvinit at all).  But it seems
sensible for the package to provide reasonable defaults that would be
acceptable to some/most distros.

p.

Re: [PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Steffen Sledz]

Am 31.08.2010 14:13, schrieb Phil Blundell:
> Yes, the DISTRO maintainers would have the final say about start/stop
> levels (and, indeed, whether to use sysvinit at all).  But it seems
> sensible for the package to provide reasonable defaults that would be
> acceptable to some/most distros.

OK. What's the best way to get the distro maintainers attention (and acks)?

Steffen

BTW: There's a new version of this patch (see later in this thread).

Re: [PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Graeme Gregory]

 On 31/08/10 13:16, Steffen Sledz wrote:
> Am 31.08.2010 14:13, schrieb Phil Blundell:
>> Yes, the DISTRO maintainers would have the final say about start/stop
>> levels (and, indeed, whether to use sysvinit at all).  But it seems
>> sensible for the package to provide reasonable defaults that would be
>> acceptable to some/most distros.
> OK. What's the best way to get the distro maintainers attention (and acks)?
>
> Steffen
>
> BTW: There's a new version of this patch (see later in this thread).
>
For Angstrom

Acked-by: Graeme Gregory <dp@xora.org.uk>

G

Re: [PATCH] rsyslog: keep rsyslog running as long as possible on shutdown

[Steffen Sledz]

Am 31.08.2010 14:21, schrieb Graeme Gregory:
> For Angstrom
> 
> Acked-by: Graeme Gregory <dp@xora.org.uk>

Is this valid for [PATCH v2]?

[PATCH v2] various syslogs: keep syslog running as long as possible on shutdown

[Steffen Sledz]

Signed-off-by: Steffen Sledz <sledz@dresearch.de>
---
 recipes/busybox/busybox.inc   |    7 +++++--
 recipes/rsyslog/rsyslog.inc   |    7 +++++--
 recipes/sysklogd/sysklogd.inc |    7 +++++--
 3 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/recipes/busybox/busybox.inc b/recipes/busybox/busybox.inc
index 96d9bb1..1046b2f 100644
--- a/recipes/busybox/busybox.inc
+++ b/recipes/busybox/busybox.inc
@@ -11,7 +11,7 @@ LICENSE = "GPLv2"
 SECTION = "base"
 PRIORITY = "required"
 
-INC_PR = "r33"
+INC_PR = "r34"
 
 SRC_URI = "\
   file://busybox-cron \
@@ -257,7 +257,10 @@ pkg_postinst_${PN}-syslog () {
 	else
 		OPT="-s"
 	fi
-	update-rc.d $OPT syslog defaults
+	# remove all rc.d-links potentially created from alternative
+	# syslog packages before creating new ones
+	update-rc.d $OPT -f syslog remove
+	update-rc.d $OPT syslog start 20 2 3 4 5 . stop 90 0 1 6 .
 }
 
 pkg_prerm_${PN}-syslog () {
diff --git a/recipes/rsyslog/rsyslog.inc b/recipes/rsyslog/rsyslog.inc
index a3bd125..8f67130 100644
--- a/recipes/rsyslog/rsyslog.inc
+++ b/recipes/rsyslog/rsyslog.inc
@@ -2,7 +2,7 @@ DESCRIPTION = "Rsyslog is an enhanced multi-threaded syslogd"
 DEPENDS = "zlib"
 HOMEPAGE = "http://www.rsyslog.com/"
 LICENSE = "GPLv3"
-INC_PR = "r1"
+INC_PR = "r2"
 
 SRC_URI = "http://www.rsyslog.com/files/download/rsyslog/${PN}-${PV}.tar.gz \
           file://rsyslog.conf \
@@ -31,7 +31,10 @@ pkg_postinst_${PN} () {
 	else
 		OPT="-s"
 	fi
-	update-rc.d $OPT syslog defaults
+	# remove all rc.d-links potentially created from alternative
+	# syslog packages before creating new ones
+	update-rc.d $OPT -f syslog remove
+	update-rc.d $OPT syslog start 20 2 3 4 5 . stop 90 0 1 6 .
 }
 
 pkg_prerm_${PN} () {
diff --git a/recipes/sysklogd/sysklogd.inc b/recipes/sysklogd/sysklogd.inc
index f25af53..833fe6a 100644
--- a/recipes/sysklogd/sysklogd.inc
+++ b/recipes/sysklogd/sysklogd.inc
@@ -1,7 +1,7 @@
 LICENSE = "GPL"
 SECTION = "base"
 DESCRIPTION = "The sysklogd package implements two system log daemons."
-INC_PR = "r3"
+INC_PR = "r4"
 
 SRC_URI = "http://www.ibiblio.org/pub/Linux/system/daemons/sysklogd-${PV}.tar.gz \
 	       file://nonrootinstall.patch \
@@ -52,7 +52,10 @@ pkg_postinst_${PN} () {
     else
 	OPT="-s"
     fi
-    update-rc.d $OPT syslog defaults
+    # remove all rc.d-links potentially created from alternative
+    # syslog packages before creating new ones
+    update-rc.d $OPT -f syslog remove
+    update-rc.d $OPT syslog start 20 2 3 4 5 . stop 90 0 1 6 .
 }
 
 pkg_prerm_${PN} () {
-- 
1.7.1