From: Rik van Riel <riel@redhat.com>
To: Ying Han <yinghan@google.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Venkatesh Pallipadi <venki@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system
Date: Sun, 29 Aug 2010 18:26:02 -0400 [thread overview]
Message-ID: <4C7ADE7A.2040909@redhat.com> (raw)
In-Reply-To: <AANLkTimjVHp1=Fc35xLnyPb2aa+ew7w1P9DC_0GfhZgY@mail.gmail.com>
On 08/29/2010 05:23 PM, Ying Han wrote:
> On Sun, Aug 29, 2010 at 1:03 PM, Rik van Riel<riel@redhat.com> wrote:
>> On 08/29/2010 01:45 PM, Ying Han wrote:
>>
>>> There are few other places in vmscan where we check nr_swap_pages and
>>> inactive_anon_is_low. Are we planning to change them to use
>>> total_swap_pages
>>> to be consistent ?
>>
>> If that makes sense, maybe the check can just be moved into
>> inactive_anon_is_low itself?
>
> That was the initial patch posted, instead we changed to use
> total_swap_pages instead. How this patch looks:
Looks good to me. It could use a comment along the lines of:
/*
* No sense scanning the anon lists if we have no swap space.
*/
... and, of course, your signed-off-by :)
--
All rights reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Ying Han <yinghan@google.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Venkatesh Pallipadi <venki@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] vmscan: prevent background aging of anon page in no swap system
Date: Sun, 29 Aug 2010 18:26:02 -0400 [thread overview]
Message-ID: <4C7ADE7A.2040909@redhat.com> (raw)
In-Reply-To: <AANLkTimjVHp1=Fc35xLnyPb2aa+ew7w1P9DC_0GfhZgY@mail.gmail.com>
On 08/29/2010 05:23 PM, Ying Han wrote:
> On Sun, Aug 29, 2010 at 1:03 PM, Rik van Riel<riel@redhat.com> wrote:
>> On 08/29/2010 01:45 PM, Ying Han wrote:
>>
>>> There are few other places in vmscan where we check nr_swap_pages and
>>> inactive_anon_is_low. Are we planning to change them to use
>>> total_swap_pages
>>> to be consistent ?
>>
>> If that makes sense, maybe the check can just be moved into
>> inactive_anon_is_low itself?
>
> That was the initial patch posted, instead we changed to use
> total_swap_pages instead. How this patch looks:
Looks good to me. It could use a comment along the lines of:
/*
* No sense scanning the anon lists if we have no swap space.
*/
... and, of course, your signed-off-by :)
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-08-29 22:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 15:43 [PATCH] vmscan: prevent background aging of anon page in no swap system Minchan Kim
2010-08-29 15:43 ` Minchan Kim
2010-08-29 15:49 ` Rik van Riel
2010-08-29 15:49 ` Rik van Riel
2010-08-29 17:45 ` Ying Han
2010-08-29 17:45 ` Ying Han
2010-08-29 20:03 ` Rik van Riel
2010-08-29 20:03 ` Rik van Riel
2010-08-29 20:56 ` Ying Han
2010-08-29 21:23 ` Ying Han
2010-08-29 21:23 ` Ying Han
2010-08-29 22:26 ` Rik van Riel [this message]
2010-08-29 22:26 ` Rik van Riel
2010-08-30 0:18 ` Minchan Kim
2010-08-30 0:18 ` Minchan Kim
2010-08-30 5:40 ` Ying Han
2010-08-30 5:40 ` Ying Han
2010-08-30 6:16 ` Minchan Kim
2010-08-30 6:16 ` Minchan Kim
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 1:10 ` Minchan Kim
2010-08-31 1:10 ` Minchan Kim
2010-08-31 1:18 ` KOSAKI Motohiro
2010-08-31 1:18 ` KOSAKI Motohiro
2010-08-31 1:36 ` Minchan Kim
2010-08-31 1:36 ` Minchan Kim
2010-08-31 1:41 ` KOSAKI Motohiro
2010-08-31 1:41 ` KOSAKI Motohiro
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 0:56 ` KOSAKI Motohiro
2010-08-31 1:23 ` Minchan Kim
2010-08-31 1:23 ` Minchan Kim
2010-08-31 1:38 ` KOSAKI Motohiro
2010-08-31 1:38 ` KOSAKI Motohiro
2010-08-31 2:02 ` Minchan Kim
2010-08-31 2:02 ` Minchan Kim
2010-08-31 2:09 ` KOSAKI Motohiro
2010-08-31 2:09 ` KOSAKI Motohiro
2010-08-31 3:47 ` Minchan Kim
2010-08-31 3:47 ` Minchan Kim
2010-08-31 2:30 ` Rik van Riel
2010-08-31 2:30 ` Rik van Riel
2010-08-31 3:46 ` Minchan Kim
2010-08-31 3:46 ` Minchan Kim
2010-09-03 21:06 ` Andrew Morton
2010-09-03 21:06 ` Andrew Morton
2010-09-03 21:23 ` Rik van Riel
2010-09-03 21:23 ` Rik van Riel
2010-09-03 21:45 ` Ying Han
2010-09-03 21:47 ` Ying Han
2010-09-03 21:47 ` Ying Han
2010-09-03 21:56 ` Andrew Morton
2010-09-03 21:56 ` Andrew Morton
2010-09-04 1:12 ` Venkatesh Pallipadi
2010-09-04 1:12 ` Venkatesh Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7ADE7A.2040909@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=venki@google.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.