All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	mingo Redhat <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	LKLM <linux-kernel@vger.kernel.org>
Subject: [lm-sensors] [Patch-next]therm_throt.c: Trival fix for a unsuitable
Date: Mon, 30 Aug 2010 07:52:56 +0000	[thread overview]
Message-ID: <4C7B6358.3040703@np.css.fujitsu.com> (raw)

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.

I don't think TMR is a suitable abbreviation for thermal.
  1.TMR has been used in IA32 Architectures Software Developer's
    Manual, and is the abbreviation for Trigger Mode Register.
  2.There is not an standard abbreviation "TMR" defined for thermal
    in IA32 Architectures Software Developer's Manual.
  3.Though we could understand it as Thermal Monitor Register, it is
    easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index d9368ee..2f9f468 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }
-- 
1.7.1.1




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
	"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	mingo Redhat <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	LKLM <linux-kernel@vger.kernel.org>
Subject: [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.
Date: Mon, 30 Aug 2010 16:52:56 +0900	[thread overview]
Message-ID: <4C7B6358.3040703@np.css.fujitsu.com> (raw)

In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.

I don't think TMR is a suitable abbreviation for thermal.
  1.TMR has been used in IA32 Architectures Software Developer's
    Manual, and is the abbreviation for Trigger Mode Register.
  2.There is not an standard abbreviation "TMR" defined for thermal
    in IA32 Architectures Software Developer's Manual.
  3.Though we could understand it as Thermal Monitor Register, it is
    easy to be misunderstood as a *TIMER* interrupt also.

I think this patch will fix it.

Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
---
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index d9368ee..2f9f468 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
 
 static void unexpected_thermal_interrupt(void)
 {
-	printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+	printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
 			smp_processor_id());
 	add_taint(TAINT_MACHINE_CHECK);
 }
-- 
1.7.1.1




             reply	other threads:[~2010-08-30  7:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30  7:52 Jin Dongming [this message]
2010-08-30  7:52 ` [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Jin Dongming
2010-08-30  7:57 ` [lm-sensors] [Patch-next]therm_throt.c: Trival fix for a Jean Delvare
2010-08-30  7:57   ` [lm-sensors] [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Jean Delvare
2010-08-31  0:13   ` [lm-sensors] [Patch-next -v2]therm_throt.c: Trival fix for a Jin Dongming
2010-08-31  0:13     ` [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Jin Dongming
2010-08-31  6:56     ` [lm-sensors] [Patch-next -v2]therm_throt.c: Trival fix for a Jean Delvare
2010-08-31  6:56       ` [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Jean Delvare
2010-08-31 17:30       ` [lm-sensors] [Patch-next -v2]therm_throt.c: Trival fix for a Fenghua Yu
2010-08-31 17:30         ` [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Fenghua Yu
2010-09-05 13:06     ` [lm-sensors] [tip:x86/debug] therm_throt.c: Trival printk message tip-bot for Jin Dongming
2010-09-05 13:06       ` [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal' tip-bot for Jin Dongming
2010-09-05 16:59       ` [lm-sensors] [tip:x86/debug] therm_throt.c: Trival printk Jean Delvare
2010-09-05 16:59         ` [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal' Jean Delvare
2010-09-05 18:30     ` [tip:x86/debug] therm_throt.c: Trivial " tip-bot for Jin Dongming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C7B6358.3040703@np.css.fujitsu.com \
    --to=jin.dongming@np.css.fujitsu.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@redhat.com \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.