* [PATCH] voicecall: Add check in dial_request_finish
@ 2010-08-30 6:28 Zhenhua Zhang
2010-08-30 15:35 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: Zhenhua Zhang @ 2010-08-30 6:28 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
To avoid signal 11 if no dial_req exists.
---
src/voicecall.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/voicecall.c b/src/voicecall.c
index 6ad58ad..1313129 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -220,6 +220,9 @@ static void dial_request_finish(struct ofono_voicecall *vc, gboolean callback)
{
struct dial_request *dial_req = vc->dial_req;
+ if (dial_req == NULL)
+ return;
+
if (callback && dial_req->cb)
dial_req->cb(dial_req->call ? dial_req->call->call : NULL,
dial_req->user_data);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] voicecall: Add check in dial_request_finish
2010-08-30 6:28 [PATCH] voicecall: Add check in dial_request_finish Zhenhua Zhang
@ 2010-08-30 15:35 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2010-08-30 15:35 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Hi Zhenhua,
On 08/30/2010 01:28 AM, Zhenhua Zhang wrote:
> To avoid signal 11 if no dial_req exists.
> ---
> src/voicecall.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/src/voicecall.c b/src/voicecall.c
> index 6ad58ad..1313129 100644
> --- a/src/voicecall.c
> +++ b/src/voicecall.c
> @@ -220,6 +220,9 @@ static void dial_request_finish(struct ofono_voicecall *vc, gboolean callback)
> {
> struct dial_request *dial_req = vc->dial_req;
>
> + if (dial_req == NULL)
> + return;
> +
> if (callback && dial_req->cb)
> dial_req->cb(dial_req->call ? dial_req->call->call : NULL,
> dial_req->user_data);
I fixed it slightly differently. Let me know if it still crashes.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-30 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-30 6:28 [PATCH] voicecall: Add check in dial_request_finish Zhenhua Zhang
2010-08-30 15:35 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.