Re: [Qemu-devel] Re: [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy.

[Jes Sorensen <Jes.Sorensen@redhat.com>]

On 08/30/10 18:29, Anthony Liguori wrote:
> On 08/30/2010 11:18 AM, Paolo Bonzini wrote:
>> It falls under the "missing fields in initializer" warning.  Arguably,
>> an empty initializer should be special cased, but it isn't.
> 
> So the warning is for old style initializer lists?  I disagree that it's
> a valid warning.  First, {} is ambiguous as it can be an empty list of
> c99 initializers and an empty list of c89 initializers.
> 
> But even for c89 initializers, it's very common practice to omit
> initializers and rely on the defaulted value.  For instance, { 0 } is
> quite pervasive as an idiom.
> 
>>
>> I agree that Jes's original patch is ugly, but the C99 initializer is
>> an improvement.
> 
> Yes, I'm fine with your patch on it's own but I disagree with GCC's
> warnings here.

So if we pulled in Paolo's version instead, would you be happy with that?

Personally I find the memset approach prettier since it's explicit what
it does, but that is obviously down to personal preference.

Cheers,
Jes