From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/14] gcc extra warning fixes
Date: Tue, 31 Aug 2010 09:21:20 +0200 [thread overview]
Message-ID: <4C7CAD70.9030705@redhat.com> (raw)
In-Reply-To: <AANLkTi=JOeDmA10ogMF+mF=ur3tEyf1Lk7nNb+ovJbdq@mail.gmail.com>
On 08/30/10 21:25, Blue Swirl wrote:
> On Mon, Aug 30, 2010 at 3:35 PM, <Jes.Sorensen@redhat.com> wrote:
>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> Hi,
>>
>> I started building QEMU with some more aggressive error flags to see
>> what dropped out. I started fixing up some of the cases, removing
>> unused arguments to functions, comparisons of unsigned types against
>> negative values etc. and a few other minor changes to avoid compiler
>> warnings.
>
> If the patches make all such warnings disappear, you could also
> consider the same approach as taken by
> 7ccfb2eb5f9d91bdb4139cb420a3b5f8deb2f6e8 and
> ac41a6206fe9e1506010cd0aa9cf56ed3b37ae19.
>
> If a GCC flag can be enabled, it should not be just -Wextra, because
> that means different things on different GCC versions, so please check
> also
> a316e3788df2781fda119e801e9b3d753f89b752.
The one GCC flag I think we should enable, and probably was the one that
caught the most bugs in my patch set is this one: -Wtype-limits
There was only one false positive with this flag in block/blkdebug.c
where it bails on a < 0 comparison of an enum. enum doesn't seem to be
defined to being signed or unsigned, but a quick cast in that case would
make that single false positive go away.
Cheers,
Jes
next prev parent reply other threads:[~2010-08-31 7:21 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 15:35 [Qemu-devel] [PATCH 00/14] gcc extra warning fixes Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 01/14] Remove unused argument for nbd_client() Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 02/14] Respect return value from nbd_client() Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 03/14] Fix repeated typo: was "end if list" instead of "end of list" Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 04/14] Zero initialize timespec struct explicitly Jes.Sorensen
2010-08-30 15:43 ` [Qemu-devel] " Anthony Liguori
2010-08-30 15:55 ` Jes Sorensen
2010-08-30 17:04 ` malc
2010-08-30 16:56 ` malc
2010-08-30 17:38 ` Jes Sorensen
2010-08-30 17:41 ` Anthony Liguori
2010-08-30 17:43 ` malc
2010-08-30 15:35 ` [Qemu-devel] [PATCH 05/14] Remove unused argument for check_for_block_signature() Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 06/14] Remove unused argument for encrypt_sectors() Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 07/14] Remove unused argument for get_whole_cluster() Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 08/14] Remove unused argument for qcow2_encrypt_sectors() Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 09/14] Remove unused arguments for add_aio_request() and free_aio_req() Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 10/14] Zero json struct with memset() instea of = {} to keep compiler happy Jes.Sorensen
2010-08-30 15:39 ` [Qemu-devel] " Anthony Liguori
2010-08-30 15:43 ` Jes Sorensen
2010-08-30 15:48 ` Anthony Liguori
2010-08-30 15:53 ` Jes Sorensen
2010-08-30 17:12 ` Avi Kivity
2010-08-30 16:55 ` Nathan Froyd
2010-08-30 18:00 ` Jes Sorensen
2010-08-30 17:06 ` malc
2010-08-30 19:32 ` Richard Henderson
2010-08-30 15:42 ` Paolo Bonzini
2010-08-30 16:15 ` Anthony Liguori
2010-08-30 16:18 ` Paolo Bonzini
2010-08-30 16:29 ` Anthony Liguori
2010-08-30 16:35 ` Paolo Bonzini
2010-08-30 18:05 ` Jes Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 11/14] Remove unused function arguments Jes.Sorensen
2010-08-30 16:24 ` [Qemu-devel] " Paolo Bonzini
2010-08-30 17:13 ` Anthony Liguori
2010-08-30 15:35 ` [Qemu-devel] [PATCH 12/14] size_t is unsigned, so (foo >= 0) is always true Jes.Sorensen
2010-08-30 15:41 ` [Qemu-devel] " Anthony Liguori
2010-08-30 15:35 ` [Qemu-devel] [PATCH 13/14] Change DPRINTF() to do{}while(0) to avoid compiler warning Jes.Sorensen
2010-08-30 15:35 ` [Qemu-devel] [PATCH 14/14] load_multiboot(): get_image_size() returns int Jes.Sorensen
2010-08-30 19:25 ` [Qemu-devel] [PATCH 00/14] gcc extra warning fixes Blue Swirl
2010-08-31 7:21 ` Jes Sorensen [this message]
2010-08-31 17:43 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7CAD70.9030705@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.