From: Ben Greear <greearb@candelatech.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [nfs] nfs: Fix nfs_sockaddr_match_ipaddr6
Date: Fri, 03 Sep 2010 09:22:43 -0700 [thread overview]
Message-ID: <4C8120D3.9040704@candelatech.com> (raw)
In-Reply-To: <1D980EDC-301A-4B4D-97D3-037B96DBAF86@oracle.com>
On 09/03/2010 09:17 AM, Chuck Lever wrote:
>
> On Sep 3, 2010, at 12:15 PM, Ben Greear wrote:
>
>> A typo caused this method not not actually compare the
>> two addresses passed in. It returned true in almost all
>> cases instead.
>
> From the perspective of the local logic, that looks correct. Have you tried this with IPv6 mounts? Notice any overall changes in behavior?
I noticed this when getting multiple NFS mounts to work with srcaddr=
The change fixed the problems I was seeing, but I haven't tested w/out
srcaddr= logic. Might need to have two different NFS servers to do a good
test of this logic, and I'm not looking forward to setting up another
open-solaris box!
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-03 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 16:15 [nfs] nfs: Fix nfs_sockaddr_match_ipaddr6 Ben Greear
2010-09-03 16:17 ` Chuck Lever
2010-09-03 16:22 ` Ben Greear [this message]
2010-09-03 16:27 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8120D3.9040704@candelatech.com \
--to=greearb@candelatech.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.