Re: [PATCH 1/3] cgroup : add clone_children control file

[Daniel Lezcano <daniel.lezcano-GANU6spQydw@public.gmane.org>]

On 09/07/2010 11:22 PM, Paul Menage wrote:
> On Tue, Sep 7, 2010 at 2:13 PM, Daniel Lezcano<daniel.lezcano-GANU6spQydw@public.gmane.org>  wrote:
>    
>> The clone_children option behaves like the release-agent mount option no ?
>>      
> Not quite, since it can be controlled on a per-cgroup basis.
>
>    
>> We can mount with a specific release agent and change it at runtime. IMHO it
>> would be better to give a chance to the administrator to set its system with
>> the mount option instead of force him to write post mount scripts. An
>> alternative would be to set this cgroup option *only* via the mount option,
>> but I am not sure it is good as it may be an unresolvable constraint for a
>> system wanting to use the cgroups with and without this option (same kind of
>> constraint we have with the ns_cgroup).
>>
>> I am favorable to keep the mount option and the ability to change it for
>> another cgroup.
>>      
> OK, lets mostly keep the current patch, but lose the flag stored at
> mount-time and just report the mount option based on the current value
> of the root cgroup's flag.
>    

Ok, will resend a new version.

Thanks for reviewing the patchset.

   -- Daniel