* Re: [PATCH] KVM: x86: fixup set_efer() [not found] <AANLkTinMZiG6iGBv+PHBw_rsn1+SJaPtDA=-zHcU0Mrf@mail.gmail.com> @ 2010-09-08 10:04 ` Avi Kivity 2010-09-09 8:37 ` Sheng Yang 0 siblings, 1 reply; 2+ messages in thread From: Avi Kivity @ 2010-09-08 10:04 UTC (permalink / raw) To: Hillf Danton; +Cc: Ben-Ami Yassour, kvm, Amit Shah, Yaniv Kamay On 09/04/2010 04:29 PM, Hillf Danton wrote: > The second call to kvm_mmu_reset_context() seems unnecessary and is > removed. > > > @@ -783,10 +783,6 @@ static int set_efer(struct kvm_vcpu *vcp > vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled; > kvm_mmu_reset_context(vcpu); > - /* Update reserved bits */ > - if ((efer ^ old_efer) & EFER_NX) > - kvm_mmu_reset_context(vcpu); > - > return 0; > } Hm. As far as I can tell, it's the first call that is unnecessary. I'll look at the history and try to understand why it was introduced. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86: fixup set_efer() 2010-09-08 10:04 ` [PATCH] KVM: x86: fixup set_efer() Avi Kivity @ 2010-09-09 8:37 ` Sheng Yang 0 siblings, 0 replies; 2+ messages in thread From: Sheng Yang @ 2010-09-09 8:37 UTC (permalink / raw) To: kvm; +Cc: Avi Kivity, Hillf Danton, Ben-Ami Yassour, Amit Shah, Yaniv Kamay On Wednesday 08 September 2010 18:04:18 Avi Kivity wrote: > On 09/04/2010 04:29 PM, Hillf Danton wrote: > > The second call to kvm_mmu_reset_context() seems unnecessary and is > > removed. > > > > > > @@ -783,10 +783,6 @@ static int set_efer(struct kvm_vcpu *vcp > > vcpu->arch.mmu.base_role.nxe = (efer & EFER_NX) && !tdp_enabled; > > kvm_mmu_reset_context(vcpu); > > - /* Update reserved bits */ > > - if ((efer ^ old_efer) & EFER_NX) > > - kvm_mmu_reset_context(vcpu); > > - > > return 0; > > > > } > > Hm. As far as I can tell, it's the first call that is unnecessary. > I'll look at the history and try to understand why it was introduced. Oops, seems my patch failed to remove the old line... -- regards Yang, Sheng ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-09 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <AANLkTinMZiG6iGBv+PHBw_rsn1+SJaPtDA=-zHcU0Mrf@mail.gmail.com>
2010-09-08 10:04 ` [PATCH] KVM: x86: fixup set_efer() Avi Kivity
2010-09-09 8:37 ` Sheng Yang
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.