[originated PATCH 0/2]

[originated PATCH 0/2]

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Hi all,

This patch adds the "Originated" property to the VoiceCall interface. It
is used to determine if the call is originated from the mobile or not.

The originated information can be deducted from the call state assuming
the client does follow the call states from the beqginning. However,
after the call gets activated call states are common for the mobile
originated and mobile terminated calls.

--Pekka

[originated PATCH 1/2] doc/voicecall: add Originated property

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

---
 doc/voicecall-api.txt |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt
index f0ba316..97b112c 100644
--- a/doc/voicecall-api.txt
+++ b/doc/voicecall-api.txt
@@ -95,6 +95,12 @@ Properties	string LineIdentification [readonly]
 			Notifications if a call becomes part or leaves a
 			multipart call are sent.
 
+		boolean Originated [readonly]
+
+			Indicates the direction of the call. This property
+			is true if the call is mobile originated (MO) or
+			false if the call is mobile terminated (MT).
+
 		string State [readonly]
 
 			Contains the state of the current call.  The state
-- 
1.7.0.4

[originated PATCH 2/2] voicecall: add "Originated" property

[Pekka.Pessi]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

From: Pekka Pessi <Pekka.Pessi@nokia.com>

---
 src/voicecall.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/src/voicecall.c b/src/voicecall.c
index 2833fc6..d61ddd1 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -234,6 +234,7 @@ static void append_voicecall_properties(struct voicecall *v,
 	const char *callerid;
 	const char *timestr;
 	ofono_bool_t mpty;
+	ofono_bool_t mo;
 
 	status = call_status_to_string(call->status);
 	callerid = phone_number_to_string(&call->phone_number);
@@ -262,6 +263,13 @@ static void append_voicecall_properties(struct voicecall *v,
 
 	ofono_dbus_dict_append(dict, "Multiparty", DBUS_TYPE_BOOLEAN, &mpty);
 
+	if (call->direction)
+		mo = FALSE;
+	else
+		mo = TRUE;
+
+	ofono_dbus_dict_append(dict, "Originated", DBUS_TYPE_BOOLEAN, &mo);
+
 	if (v->message)
 		ofono_dbus_dict_append(dict, "Information", DBUS_TYPE_STRING,
 					&v->message);
-- 
1.7.0.4

Re: [originated PATCH 0/2]

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

Hi Pekka,

On 09/06/2010 10:09 AM, Pekka.Pessi(a)nokia.com wrote:
> Hi all,
> 
> This patch adds the "Originated" property to the VoiceCall interface. It
> is used to determine if the call is originated from the mobile or not.

Just throwing ideas, but would 'string Direction' with possible values
"in" or "incoming" and "out" or "outgoing" be a bit clearer?

> 
> The originated information can be deducted from the call state assuming
> the client does follow the call states from the beqginning. However,
> after the call gets activated call states are common for the mobile
> originated and mobile terminated calls.

Out of curiosity, how exactly is this useful?

Regards,
-Denis

Re: [originated PATCH 0/2]

[Pekka Pessi]

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

Hi Denis,

>> This patch adds the "Originated" property to the VoiceCall interface. It
>> is used to determine if the call is originated from the mobile or not.
>
> Just throwing ideas, but would 'string Direction' with possible values
> "in" or "incoming" and "out" or "outgoing" be a bit clearer?

It sounds better, yes.

>> The originated information can be deducted from the call state assuming
>> the client does follow the call states from the beqginning. However,
>> after the call gets activated call states are common for the mobile
>> originated and mobile terminated calls.
>
> Out of curiosity, how exactly is this useful?

For logging purposes. Recovering after a call-related server.

There might be some weird calls with no intermediate calls where there
are no intermediate states, too. SRVCC comes to mind, there the cs
call gets created out of thin air.

-- 
Pekka.Pessi mail at nokia.com