All of lore.kernel.org
 help / color / mirror / Atom feed
* [refpolicy] [Acct 1/1] Clean up acct module.
@ 2010-09-03 15:46 Dominick Grift
  2010-09-09 12:11 ` Christopher J. PeBenito
  0 siblings, 1 reply; 2+ messages in thread
From: Dominick Grift @ 2010-09-03 15:46 UTC (permalink / raw)
  To: refpolicy

Signed-off-by: Dominick Grift <domg472@gmail.com>
---
:100644 100644 e81367c... 99ff9aa... M	policy/modules/admin/acct.fc
:100644 100644 e66c296... 1a5c801... M	policy/modules/admin/acct.if
 policy/modules/admin/acct.fc |    1 -
 policy/modules/admin/acct.if |   11 ++++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/policy/modules/admin/acct.fc b/policy/modules/admin/acct.fc
index e81367c..99ff9aa 100644
--- a/policy/modules/admin/acct.fc
+++ b/policy/modules/admin/acct.fc
@@ -1,4 +1,3 @@
-
 /etc/cron\.(daily|monthly)/acct -- gen_context(system_u:object_r:acct_exec_t,s0)
 
 /sbin/accton		--	gen_context(system_u:object_r:acct_exec_t,s0)
diff --git a/policy/modules/admin/acct.if b/policy/modules/admin/acct.if
index e66c296..1a5c801 100644
--- a/policy/modules/admin/acct.if
+++ b/policy/modules/admin/acct.if
@@ -1,8 +1,9 @@
-## <summary>Berkeley process accounting</summary>
+## <summary>Berkeley process accounting.</summary>
 
 ########################################
 ## <summary>
-##	Transition to the accounting management domain.
+##	Execute a domain transition to run
+##	accounting management tools.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
@@ -21,7 +22,7 @@ interface(`acct_domtrans',`
 
 ########################################
 ## <summary>
-##	Execute accounting management tools in the caller domain.
+##	Execute accounting management tools.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
@@ -40,7 +41,7 @@ interface(`acct_exec',`
 
 ########################################
 ## <summary>
-##	Execute accounting management data in the caller domain.
+##	Execute accounting management data.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
@@ -61,7 +62,7 @@ interface(`acct_exec_data',`
 
 ########################################
 ## <summary>
-##	Create, read, write, and delete process accounting data.
+##	Manage accounting data.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
-- 
1.7.2.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100903/23931dfd/attachment.bin 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [refpolicy] [Acct 1/1] Clean up acct module.
  2010-09-03 15:46 [refpolicy] [Acct 1/1] Clean up acct module Dominick Grift
@ 2010-09-09 12:11 ` Christopher J. PeBenito
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher J. PeBenito @ 2010-09-09 12:11 UTC (permalink / raw)
  To: refpolicy

On 09/03/10 11:46, Dominick Grift wrote:
> --- a/policy/modules/admin/acct.if
> +++ b/policy/modules/admin/acct.if
> @@ -1,8 +1,9 @@
> -##<summary>Berkeley process accounting</summary>
> +##<summary>Berkeley process accounting.</summary>
>
>   ########################################
>   ##<summary>
> -##	Transition to the accounting management domain.
> +##	Execute a domain transition to run
> +##	accounting management tools.
>   ##</summary>
>   ##<param name="domain">
>   ##	<summary>
> @@ -21,7 +22,7 @@ interface(`acct_domtrans',`
>
>   ########################################
>   ##<summary>
> -##	Execute accounting management tools in the caller domain.
> +##	Execute accounting management tools.
>   ##</summary>
>   ##<param name="domain">
>   ##	<summary>
> @@ -40,7 +41,7 @@ interface(`acct_exec',`
>
>   ########################################
>   ##<summary>
> -##	Execute accounting management data in the caller domain.
> +##	Execute accounting management data.
>   ##</summary>
>   ##<param name="domain">
>   ##	<summary>
> @@ -61,7 +62,7 @@ interface(`acct_exec_data',`
>
>   ########################################
>   ##<summary>
> -##	Create, read, write, and delete process accounting data.
> +##	Manage accounting data.
>   ##</summary>
>   ##<param name="domain">
>   ##	<summary>

This one makes it worse, in my opinion.  I prefer to keep the "create, 
read, write, and delete" so that people that aren't as familiar with 
what we mean by "manage" have an idea of what it means by the docs.

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-09 12:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-03 15:46 [refpolicy] [Acct 1/1] Clean up acct module Dominick Grift
2010-09-09 12:11 ` Christopher J. PeBenito

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.