From: David Daney <ddaney@caviumnetworks.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] MIPS: DMA: Add plat_extra_sync_for_cpu()
Date: Thu, 09 Sep 2010 10:10:00 -0700 [thread overview]
Message-ID: <4C8914E8.5030002@caviumnetworks.com> (raw)
In-Reply-To: <99a0868bdbcfa8785a92b4af4f6d9b99@localhost>
On 09/08/2010 04:02 PM, Kevin Cernekee wrote:
> On noncoherent processors with a readahead cache, an extra platform-
> specific invalidation is required during the dma_sync_*_for_cpu()
> operations to keep drivers from seeing stale prefetched data.
>
> Signed-off-by: Kevin Cernekee<cernekee@gmail.com>
> ---
> .../include/asm/mach-cavium-octeon/dma-coherence.h | 13 +++++++++++++
> arch/mips/include/asm/mach-generic/dma-coherence.h | 13 +++++++++++++
> arch/mips/include/asm/mach-ip27/dma-coherence.h | 13 +++++++++++++
> arch/mips/include/asm/mach-ip32/dma-coherence.h | 13 +++++++++++++
> arch/mips/include/asm/mach-jazz/dma-coherence.h | 13 +++++++++++++
> .../mips/include/asm/mach-loongson/dma-coherence.h | 13 +++++++++++++
> arch/mips/include/asm/mach-powertv/dma-coherence.h | 13 +++++++++++++
> arch/mips/mm/dma-default.c | 3 +++
> 8 files changed, 94 insertions(+), 0 deletions(-)
>
[...]
But as far as I can see, none of your plat_extra_sync_for_cpu() do anything.
Perhaps adding this hook should be deferred until there is actually a user.
David Daney
next prev parent reply other threads:[~2010-09-09 17:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 23:02 [PATCH v2 1/3] MIPS: HIGHMEM DMA on noncoherent MIPS32 processors Kevin Cernekee
2010-09-08 23:02 ` Kevin Cernekee
2010-09-08 23:02 ` [PATCH 2/3] MIPS: Allow UserLocal on MIPS_R1 processors Kevin Cernekee
2010-09-08 23:02 ` Kevin Cernekee
2010-09-09 9:53 ` Ralf Baechle
2010-09-08 23:02 ` [PATCH 3/3] MIPS: DMA: Add plat_extra_sync_for_cpu() Kevin Cernekee
2010-09-08 23:02 ` Kevin Cernekee
2010-09-09 9:34 ` Sergei Shtylyov
2010-09-09 12:39 ` Kevin Cernekee
2011-05-19 13:30 ` Ralf Baechle
2010-09-09 17:10 ` David Daney [this message]
2010-09-09 17:34 ` Thomas Bogendoerfer
2010-09-09 18:35 ` Kevin Cernekee
2010-09-09 18:58 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8914E8.5030002@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=cernekee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.