From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
Daniel Walker <dwalker@codeaurora.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Steve Muckle <smuckle@codeaurora.org>,
Jeff Ohlstein <johlstei@codeaurora.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] arm: Kconfig option for ARCH_MSM_SCORPIONMP
Date: Sat, 11 Sep 2010 15:02:14 +0400 [thread overview]
Message-ID: <4C8B61B6.9020305@ru.mvista.com> (raw)
In-Reply-To: <20100910145137.GB20509@pengutronix.de>
Hello.
On 10-09-2010 18:51, Uwe Kleine-König wrote:
>>> From: Steve Muckle<smuckle@codeaurora.org>
>>> ScorpionMP is a configuration of Scorpion processors. It supports local
>>> timers.
>>> Signed-off-by: Steve Muckle<smuckle@codeaurora.org>
>>> Signed-off-by: Jeff Ohlstein<johlstei@codeaurora.org>
>>> Signed-off-by: Daniel Walker<dwalker@codeaurora.org>
>> [...]
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index a7ed21f..d2dfbc2 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -1144,7 +1144,8 @@ config SMP
>>> bool "Symmetric Multi-Processing (EXPERIMENTAL)"
>>> depends on EXPERIMENTAL&& (REALVIEW_EB_ARM11MP || REALVIEW_EB_A9MP ||\
>>> MACH_REALVIEW_PB11MP || MACH_REALVIEW_PBX || ARCH_OMAP4 ||\
>>> - ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4)
>>> + ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4||\
>>> + ARCH_MSM_SCORPIONMP)
>>> depends on GENERIC_CLOCKEVENTS
>>> select USE_GENERIC_SMP_HELPERS
>>> select HAVE_ARM_SCU if ARCH_REALVIEW || ARCH_OMAP4 || ARCH_S5PV310 ||\
>>> @@ -1218,7 +1219,8 @@ config LOCAL_TIMERS
>>> bool "Use local timer interrupts"
>>> depends on SMP&& (REALVIEW_EB_ARM11MP || MACH_REALVIEW_PB11MP || \
>>> REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
>>> - ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4)
>>> + ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4 ||\
>> Could you put spce before \ to keep the style consistent?
> It's at least locally consistent, isn't it?
Not really. The second 'bool' has spaces before \, only the first one
doesn't...
> Uwe
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] arm: Kconfig option for ARCH_MSM_SCORPIONMP
Date: Sat, 11 Sep 2010 15:02:14 +0400 [thread overview]
Message-ID: <4C8B61B6.9020305@ru.mvista.com> (raw)
In-Reply-To: <20100910145137.GB20509@pengutronix.de>
Hello.
On 10-09-2010 18:51, Uwe Kleine-K?nig wrote:
>>> From: Steve Muckle<smuckle@codeaurora.org>
>>> ScorpionMP is a configuration of Scorpion processors. It supports local
>>> timers.
>>> Signed-off-by: Steve Muckle<smuckle@codeaurora.org>
>>> Signed-off-by: Jeff Ohlstein<johlstei@codeaurora.org>
>>> Signed-off-by: Daniel Walker<dwalker@codeaurora.org>
>> [...]
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index a7ed21f..d2dfbc2 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -1144,7 +1144,8 @@ config SMP
>>> bool "Symmetric Multi-Processing (EXPERIMENTAL)"
>>> depends on EXPERIMENTAL&& (REALVIEW_EB_ARM11MP || REALVIEW_EB_A9MP ||\
>>> MACH_REALVIEW_PB11MP || MACH_REALVIEW_PBX || ARCH_OMAP4 ||\
>>> - ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4)
>>> + ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4||\
>>> + ARCH_MSM_SCORPIONMP)
>>> depends on GENERIC_CLOCKEVENTS
>>> select USE_GENERIC_SMP_HELPERS
>>> select HAVE_ARM_SCU if ARCH_REALVIEW || ARCH_OMAP4 || ARCH_S5PV310 ||\
>>> @@ -1218,7 +1219,8 @@ config LOCAL_TIMERS
>>> bool "Use local timer interrupts"
>>> depends on SMP&& (REALVIEW_EB_ARM11MP || MACH_REALVIEW_PB11MP || \
>>> REALVIEW_EB_A9MP || MACH_REALVIEW_PBX || ARCH_OMAP4 || \
>>> - ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4)
>>> + ARCH_S5PV310 || ARCH_TEGRA || ARCH_U8500 || ARCH_VEXPRESS_CA9X4 ||\
>> Could you put spce before \ to keep the style consistent?
> It's at least locally consistent, isn't it?
Not really. The second 'bool' has spaces before \, only the first one
doesn't...
> Uwe
WBR, Sergei
next prev parent reply other threads:[~2010-09-11 11:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 19:58 [GIT PULL] generic arm MSM changes for v2.6.37 Daniel Walker
2010-09-09 19:58 ` Daniel Walker
2010-09-09 19:58 ` [PATCH 1/4] arm: Kconfig option for ARCH_MSM_SCORPIONMP Daniel Walker
2010-09-09 19:58 ` Daniel Walker
2010-09-10 10:14 ` Sergei Shtylyov
2010-09-10 10:14 ` Sergei Shtylyov
2010-09-10 14:51 ` Uwe Kleine-König
2010-09-10 14:51 ` Uwe Kleine-König
2010-09-10 15:04 ` Daniel Walker
2010-09-10 15:04 ` Daniel Walker
2010-09-11 11:02 ` Sergei Shtylyov [this message]
2010-09-11 11:02 ` Sergei Shtylyov
2010-09-10 15:15 ` Lorenzo Pieralisi
2010-09-10 15:15 ` Lorenzo Pieralisi
2010-09-10 20:36 ` Russell King - ARM Linux
2010-09-10 20:36 ` Russell King - ARM Linux
2010-09-10 21:01 ` Daniel Walker
2010-09-10 21:01 ` Daniel Walker
2010-09-09 19:58 ` [PATCH 2/4] arm: dis-allow hotplug on MSM Daniel Walker
2010-09-09 19:58 ` Daniel Walker
2010-09-30 7:19 ` Pavel Machek
2010-09-30 7:19 ` Pavel Machek
2010-09-30 16:45 ` Daniel Walker
2010-09-30 16:45 ` Daniel Walker
2010-09-30 18:09 ` Daniel Walker
2010-09-30 18:09 ` Daniel Walker
2010-09-30 19:52 ` Pavel Machek
2010-09-30 19:52 ` Pavel Machek
2010-09-30 19:55 ` Daniel Walker
2010-09-30 19:55 ` Daniel Walker
2010-09-30 20:02 ` Pavel Machek
2010-09-30 20:02 ` Pavel Machek
2010-09-30 20:08 ` Daniel Walker
2010-09-30 20:08 ` Daniel Walker
2010-09-30 20:17 ` Russell King - ARM Linux
2010-09-30 20:17 ` Russell King - ARM Linux
2010-09-30 20:40 ` Daniel Walker
2010-09-30 20:40 ` Daniel Walker
2010-09-30 20:48 ` Russell King - ARM Linux
2010-09-30 20:48 ` Russell King - ARM Linux
2010-09-09 19:58 ` [PATCH 3/4] arm: mm: add proc info for ARM11MPCore/Cortex-A9 from ARM Daniel Walker
2010-09-09 19:58 ` Daniel Walker
2010-09-13 12:05 ` Catalin Marinas
2010-09-13 12:05 ` Catalin Marinas
2010-09-09 19:58 ` [PATCH 4/4] GIC: Dont disable INT in ack callback Daniel Walker
2010-09-09 19:58 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8B61B6.9020305@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=catalin.marinas@arm.com \
--cc=dwalker@codeaurora.org \
--cc=johlstei@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=smuckle@codeaurora.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.