From: Hans de Goede <hdegoede@redhat.com>
To: Andy Walls <awalls@md.metrocast.net>
Cc: linux-media@vger.kernel.org, Jean-Francois Moine <moinejf@free.fr>
Subject: Re: [PATCH v2 2/3] gspca_cpia1: Restore QX3 illuminators' state on resume
Date: Mon, 13 Sep 2010 09:18:25 +0200 [thread overview]
Message-ID: <4C8DD041.4010207@redhat.com> (raw)
In-Reply-To: <1284313518.2027.31.camel@morgan.silverblock.net>
Ack!
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 09/12/2010 07:45 PM, Andy Walls wrote:
> Turn the lights of the QX3 on (or off) as needed when resuming and at module
> load.
>
> Signed-off-by: Andy Walls<awalls@md.metrocast.net>
>
> diff -r f09faf8dd85d -r 5e576066eeaf linux/drivers/media/video/gspca/cpia1.c
> --- a/linux/drivers/media/video/gspca/cpia1.c Sun Sep 12 12:43:45 2010 -0400
> +++ b/linux/drivers/media/video/gspca/cpia1.c Sun Sep 12 12:47:00 2010 -0400
> @@ -1756,6 +1756,10 @@
> if (ret)
> return ret;
>
> + /* Ensure the QX3 illuminators' states are restored upon resume */
> + if (sd->params.qx3.qx3_detected)
> + command_setlights(gspca_dev);
> +
> sd_stopN(gspca_dev);
>
> PDEBUG(D_PROBE, "CPIA Version: %d.%02d (%d.%d)",
>
>
>
>
>
>
>
prev parent reply other threads:[~2010-09-13 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 17:45 [PATCH v2 2/3] gspca_cpia1: Restore QX3 illuminators' state on resume Andy Walls
2010-09-13 7:18 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8DD041.4010207@redhat.com \
--to=hdegoede@redhat.com \
--cc=awalls@md.metrocast.net \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.