* [PATCH v2 2/3] gspca_cpia1: Restore QX3 illuminators' state on resume
@ 2010-09-12 17:45 Andy Walls
2010-09-13 7:18 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Andy Walls @ 2010-09-12 17:45 UTC (permalink / raw)
To: linux-media; +Cc: Hans de Goede, Jean-Francois Moine
Turn the lights of the QX3 on (or off) as needed when resuming and at module
load.
Signed-off-by: Andy Walls <awalls@md.metrocast.net>
diff -r f09faf8dd85d -r 5e576066eeaf linux/drivers/media/video/gspca/cpia1.c
--- a/linux/drivers/media/video/gspca/cpia1.c Sun Sep 12 12:43:45 2010 -0400
+++ b/linux/drivers/media/video/gspca/cpia1.c Sun Sep 12 12:47:00 2010 -0400
@@ -1756,6 +1756,10 @@
if (ret)
return ret;
+ /* Ensure the QX3 illuminators' states are restored upon resume */
+ if (sd->params.qx3.qx3_detected)
+ command_setlights(gspca_dev);
+
sd_stopN(gspca_dev);
PDEBUG(D_PROBE, "CPIA Version: %d.%02d (%d.%d)",
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/3] gspca_cpia1: Restore QX3 illuminators' state on resume
2010-09-12 17:45 [PATCH v2 2/3] gspca_cpia1: Restore QX3 illuminators' state on resume Andy Walls
@ 2010-09-13 7:18 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2010-09-13 7:18 UTC (permalink / raw)
To: Andy Walls; +Cc: linux-media, Jean-Francois Moine
Ack!
Acked-by: Hans de Goede <hdegoede@redhat.com>
On 09/12/2010 07:45 PM, Andy Walls wrote:
> Turn the lights of the QX3 on (or off) as needed when resuming and at module
> load.
>
> Signed-off-by: Andy Walls<awalls@md.metrocast.net>
>
> diff -r f09faf8dd85d -r 5e576066eeaf linux/drivers/media/video/gspca/cpia1.c
> --- a/linux/drivers/media/video/gspca/cpia1.c Sun Sep 12 12:43:45 2010 -0400
> +++ b/linux/drivers/media/video/gspca/cpia1.c Sun Sep 12 12:47:00 2010 -0400
> @@ -1756,6 +1756,10 @@
> if (ret)
> return ret;
>
> + /* Ensure the QX3 illuminators' states are restored upon resume */
> + if (sd->params.qx3.qx3_detected)
> + command_setlights(gspca_dev);
> +
> sd_stopN(gspca_dev);
>
> PDEBUG(D_PROBE, "CPIA Version: %d.%02d (%d.%d)",
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-13 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-12 17:45 [PATCH v2 2/3] gspca_cpia1: Restore QX3 illuminators' state on resume Andy Walls
2010-09-13 7:18 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.