All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gong <gong.chen@linux.intel.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: fenghua.yu@intel.com, khali@linux-fr.org,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de
Subject: Re: [lm-sensors] [PATCH] x86/hwmon: fix initialization of coretemp
Date: Tue, 14 Sep 2010 06:34:55 +0000	[thread overview]
Message-ID: <4C8F178F.2080306@linux.intel.com> (raw)
In-Reply-To: <4C8E16770200007800015ACC@vpn.id2.novell.com>

于 9/13/2010 6:17 PM, Jan Beulich 写道:
> Using cpuid_eax() to determine feature availability on other than
> the current CPU is invalid. And feature availability should also be
> checked in the hotplug code path.
>
> Signed-off-by: Jan Beulich<jbeulich@novell.com>
> Cc: Rudolf Marek<r.marek@assembler.cz>
>
> ---
>   arch/x86/include/asm/cpufeature.h |    1 +
>   arch/x86/kernel/cpu/scattered.c   |    1 +
>   drivers/hwmon/coretemp.c          |   29 +++++++++++++----------------
>   3 files changed, 15 insertions(+), 16 deletions(-)
>
> --- linux-2.6.36-rc4/arch/x86/include/asm/cpufeature.h	2010-09-13 08:44:55.000000000 +0200
> +++ 2.6.36-rc4-x86-coretemp-feature-check/arch/x86/include/asm/cpufeature.h	2010-09-01 09:18:17.000000000 +0200
> @@ -168,6 +168,7 @@
>   #define X86_FEATURE_XSAVEOPT	(7*32+ 4) /* Optimized Xsave */
>   #define X86_FEATURE_PLN		(7*32+ 5) /* Intel Power Limit Notification */
>   #define X86_FEATURE_PTS		(7*32+ 6) /* Intel Package Thermal Status */
> +#define X86_FEATURE_DTS		(7*32+ 7) /* Digital Thermal Sensor */

Do we really need a new CPU flag ?

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Chen Gong <gong.chen@linux.intel.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: fenghua.yu@intel.com, khali@linux-fr.org,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
	hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de
Subject: Re: [lm-sensors] [PATCH] x86/hwmon: fix initialization of coretemp
Date: Tue, 14 Sep 2010 14:34:55 +0800	[thread overview]
Message-ID: <4C8F178F.2080306@linux.intel.com> (raw)
In-Reply-To: <4C8E16770200007800015ACC@vpn.id2.novell.com>

于 9/13/2010 6:17 PM, Jan Beulich 写道:
> Using cpuid_eax() to determine feature availability on other than
> the current CPU is invalid. And feature availability should also be
> checked in the hotplug code path.
>
> Signed-off-by: Jan Beulich<jbeulich@novell.com>
> Cc: Rudolf Marek<r.marek@assembler.cz>
>
> ---
>   arch/x86/include/asm/cpufeature.h |    1 +
>   arch/x86/kernel/cpu/scattered.c   |    1 +
>   drivers/hwmon/coretemp.c          |   29 +++++++++++++----------------
>   3 files changed, 15 insertions(+), 16 deletions(-)
>
> --- linux-2.6.36-rc4/arch/x86/include/asm/cpufeature.h	2010-09-13 08:44:55.000000000 +0200
> +++ 2.6.36-rc4-x86-coretemp-feature-check/arch/x86/include/asm/cpufeature.h	2010-09-01 09:18:17.000000000 +0200
> @@ -168,6 +168,7 @@
>   #define X86_FEATURE_XSAVEOPT	(7*32+ 4) /* Optimized Xsave */
>   #define X86_FEATURE_PLN		(7*32+ 5) /* Intel Power Limit Notification */
>   #define X86_FEATURE_PTS		(7*32+ 6) /* Intel Package Thermal Status */
> +#define X86_FEATURE_DTS		(7*32+ 7) /* Digital Thermal Sensor */

Do we really need a new CPU flag ?

  parent reply	other threads:[~2010-09-14  6:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 10:17 [lm-sensors] [PATCH] x86/hwmon: fix initialization of coretemp Jan Beulich
2010-09-13 10:17 ` Jan Beulich
2010-09-13 10:18 ` [lm-sensors] [PATCH] x86/hwmon: fix initialization of pkgtemp Jan Beulich
2010-09-13 10:18   ` Jan Beulich
2010-09-14  6:34 ` Chen Gong [this message]
2010-09-14  6:34   ` [lm-sensors] [PATCH] x86/hwmon: fix initialization of coretemp Chen Gong
2010-09-14  6:44   ` Jan Beulich
2010-09-14  6:44     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8F178F.2080306@linux.intel.com \
    --to=gong.chen@linux.intel.com \
    --cc=JBeulich@novell.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.