* [lm-sensors] [PATCH] x86/hwmon: {core, pkg,
@ 2010-09-13 10:30 ` Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2010-09-13 10:30 UTC (permalink / raw)
To: khali; +Cc: lm-sensors, linux-kernel
... as they're being called only from a __cpuinit function.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
drivers/hwmon/coretemp.c | 2 +-
drivers/hwmon/pkgtemp.c | 2 +-
drivers/hwmon/via-cputemp.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000 +0200
+++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03 17:54:14.000000000 +0200
@@ -480,7 +480,7 @@ exit:
return err;
}
-static void coretemp_device_remove(unsigned int cpu)
+static void __cpuinit coretemp_device_remove(unsigned int cpu)
{
struct pdev_entry *p, *n;
mutex_lock(&pdev_list_mutex);
--- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000 +0200
+++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01 09:00:45.000000000 +0200
@@ -337,7 +337,7 @@ exit:
}
#ifdef CONFIG_HOTPLUG_CPU
-static void pkgtemp_device_remove(unsigned int cpu)
+static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
{
struct pdev_entry *p, *n;
unsigned int i;
--- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13 08:45:03.000000000 +0200
+++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13 00:00:00.000000000 +0200
@@ -238,7 +238,7 @@ exit:
}
#ifdef CONFIG_HOTPLUG_CPU
-static void via_cputemp_device_remove(unsigned int cpu)
+static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
{
struct pdev_entry *p, *n;
mutex_lock(&pdev_list_mutex);
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] x86/hwmon: {core,pkg,via-cpu}temp_device_remove() can all be __cpuinit
@ 2010-09-13 10:30 ` Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2010-09-13 10:30 UTC (permalink / raw)
To: khali; +Cc: lm-sensors, linux-kernel
... as they're being called only from a __cpuinit function.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
drivers/hwmon/coretemp.c | 2 +-
drivers/hwmon/pkgtemp.c | 2 +-
drivers/hwmon/via-cputemp.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000 +0200
+++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03 17:54:14.000000000 +0200
@@ -480,7 +480,7 @@ exit:
return err;
}
-static void coretemp_device_remove(unsigned int cpu)
+static void __cpuinit coretemp_device_remove(unsigned int cpu)
{
struct pdev_entry *p, *n;
mutex_lock(&pdev_list_mutex);
--- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000 +0200
+++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01 09:00:45.000000000 +0200
@@ -337,7 +337,7 @@ exit:
}
#ifdef CONFIG_HOTPLUG_CPU
-static void pkgtemp_device_remove(unsigned int cpu)
+static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
{
struct pdev_entry *p, *n;
unsigned int i;
--- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13 08:45:03.000000000 +0200
+++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13 00:00:00.000000000 +0200
@@ -238,7 +238,7 @@ exit:
}
#ifdef CONFIG_HOTPLUG_CPU
-static void via_cputemp_device_remove(unsigned int cpu)
+static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
{
struct pdev_entry *p, *n;
mutex_lock(&pdev_list_mutex);
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] x86/hwmon: {core, pkg,
2010-09-13 10:30 ` [PATCH] x86/hwmon: {core,pkg,via-cpu}temp_device_remove() can all be __cpuinit Jan Beulich
@ 2010-09-14 7:24 ` Chen Gong
-1 siblings, 0 replies; 8+ messages in thread
From: Chen Gong @ 2010-09-14 7:24 UTC (permalink / raw)
To: Jan Beulich; +Cc: khali, linux-kernel, lm-sensors
于 9/13/2010 6:30 PM, Jan Beulich 写道:
> ... as they're being called only from a __cpuinit function.
>
> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>
> ---
> drivers/hwmon/coretemp.c | 2 +-
> drivers/hwmon/pkgtemp.c | 2 +-
> drivers/hwmon/via-cputemp.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000 +0200
> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03 17:54:14.000000000 +0200
> @@ -480,7 +480,7 @@ exit:
> return err;
> }
>
> -static void coretemp_device_remove(unsigned int cpu)
> +static void __cpuinit coretemp_device_remove(unsigned int cpu)
> {
> struct pdev_entry *p, *n;
> mutex_lock(&pdev_list_mutex);
> --- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000 +0200
> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01 09:00:45.000000000 +0200
> @@ -337,7 +337,7 @@ exit:
> }
>
> #ifdef CONFIG_HOTPLUG_CPU
> -static void pkgtemp_device_remove(unsigned int cpu)
> +static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
> {
> struct pdev_entry *p, *n;
> unsigned int i;
> --- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13 08:45:03.000000000 +0200
> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13 00:00:00.000000000 +0200
> @@ -238,7 +238,7 @@ exit:
> }
>
> #ifdef CONFIG_HOTPLUG_CPU
> -static void via_cputemp_device_remove(unsigned int cpu)
> +static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
> {
> struct pdev_entry *p, *n;
> mutex_lock(&pdev_list_mutex);
>
>
>
>
I think the change in the coretemp.c is needed but other 2 are
unnecessary because CONFIG_HOTPLUG_CPU has covered the codes final
status after init done.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] x86/hwmon: {core, pkg, via-cpu}temp_device_remove() can all be __cpuinit
@ 2010-09-14 7:24 ` Chen Gong
0 siblings, 0 replies; 8+ messages in thread
From: Chen Gong @ 2010-09-14 7:24 UTC (permalink / raw)
To: Jan Beulich; +Cc: khali, linux-kernel, lm-sensors
于 9/13/2010 6:30 PM, Jan Beulich 写道:
> ... as they're being called only from a __cpuinit function.
>
> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>
> ---
> drivers/hwmon/coretemp.c | 2 +-
> drivers/hwmon/pkgtemp.c | 2 +-
> drivers/hwmon/via-cputemp.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> --- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000 +0200
> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03 17:54:14.000000000 +0200
> @@ -480,7 +480,7 @@ exit:
> return err;
> }
>
> -static void coretemp_device_remove(unsigned int cpu)
> +static void __cpuinit coretemp_device_remove(unsigned int cpu)
> {
> struct pdev_entry *p, *n;
> mutex_lock(&pdev_list_mutex);
> --- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000 +0200
> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01 09:00:45.000000000 +0200
> @@ -337,7 +337,7 @@ exit:
> }
>
> #ifdef CONFIG_HOTPLUG_CPU
> -static void pkgtemp_device_remove(unsigned int cpu)
> +static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
> {
> struct pdev_entry *p, *n;
> unsigned int i;
> --- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13 08:45:03.000000000 +0200
> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13 00:00:00.000000000 +0200
> @@ -238,7 +238,7 @@ exit:
> }
>
> #ifdef CONFIG_HOTPLUG_CPU
> -static void via_cputemp_device_remove(unsigned int cpu)
> +static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
> {
> struct pdev_entry *p, *n;
> mutex_lock(&pdev_list_mutex);
>
>
>
>
I think the change in the coretemp.c is needed but other 2 are
unnecessary because CONFIG_HOTPLUG_CPU has covered the codes final
status after init done.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] x86/hwmon: {core, pkg,
2010-09-14 7:24 ` [lm-sensors] [PATCH] x86/hwmon: {core, pkg, via-cpu}temp_device_remove() can all be __cpuinit Chen Gong
@ 2010-09-14 7:35 ` Jan Beulich
-1 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2010-09-14 7:35 UTC (permalink / raw)
To: Chen Gong; +Cc: khali, lm-sensors, linux-kernel
>>> On 14.09.10 at 09:24, Chen Gong <gong.chen@linux.intel.com> wrote:
> 于 9/13/2010 6:30 PM, Jan Beulich 写道:
>> ... as they're being called only from a __cpuinit function.
>>
>> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>>
>> ---
>> drivers/hwmon/coretemp.c | 2 +-
>> drivers/hwmon/pkgtemp.c | 2 +-
>> drivers/hwmon/via-cputemp.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> --- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000
> +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03
> 17:54:14.000000000 +0200
>> @@ -480,7 +480,7 @@ exit:
>> return err;
>> }
>>
>> -static void coretemp_device_remove(unsigned int cpu)
>> +static void __cpuinit coretemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> mutex_lock(&pdev_list_mutex);
>> --- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000
> +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01
> 09:00:45.000000000 +0200
>> @@ -337,7 +337,7 @@ exit:
>> }
>>
>> #ifdef CONFIG_HOTPLUG_CPU
>> -static void pkgtemp_device_remove(unsigned int cpu)
>> +static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> unsigned int i;
>> --- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13
> 08:45:03.000000000 +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13
> 00:00:00.000000000 +0200
>> @@ -238,7 +238,7 @@ exit:
>> }
>>
>> #ifdef CONFIG_HOTPLUG_CPU
>> -static void via_cputemp_device_remove(unsigned int cpu)
>> +static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> mutex_lock(&pdev_list_mutex);
>>
>>
>>
>>
>
> I think the change in the coretemp.c is needed but other 2 are
> unnecessary because CONFIG_HOTPLUG_CPU has covered the codes final
> status after init done.
Perhaps you're right, but (just like was done for coretemp) these
CONFIG_HOTPLUG_CPU conditionals are really superfluous and should
go away.
Jan
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] x86/hwmon: {core,pkg,via-cpu}temp_device_remove() can all be __cpuinit
@ 2010-09-14 7:35 ` Jan Beulich
0 siblings, 0 replies; 8+ messages in thread
From: Jan Beulich @ 2010-09-14 7:35 UTC (permalink / raw)
To: Chen Gong; +Cc: khali, lm-sensors, linux-kernel
>>> On 14.09.10 at 09:24, Chen Gong <gong.chen@linux.intel.com> wrote:
> 于 9/13/2010 6:30 PM, Jan Beulich 写道:
>> ... as they're being called only from a __cpuinit function.
>>
>> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>>
>> ---
>> drivers/hwmon/coretemp.c | 2 +-
>> drivers/hwmon/pkgtemp.c | 2 +-
>> drivers/hwmon/via-cputemp.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> --- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000
> +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03
> 17:54:14.000000000 +0200
>> @@ -480,7 +480,7 @@ exit:
>> return err;
>> }
>>
>> -static void coretemp_device_remove(unsigned int cpu)
>> +static void __cpuinit coretemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> mutex_lock(&pdev_list_mutex);
>> --- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000
> +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01
> 09:00:45.000000000 +0200
>> @@ -337,7 +337,7 @@ exit:
>> }
>>
>> #ifdef CONFIG_HOTPLUG_CPU
>> -static void pkgtemp_device_remove(unsigned int cpu)
>> +static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> unsigned int i;
>> --- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13
> 08:45:03.000000000 +0200
>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13
> 00:00:00.000000000 +0200
>> @@ -238,7 +238,7 @@ exit:
>> }
>>
>> #ifdef CONFIG_HOTPLUG_CPU
>> -static void via_cputemp_device_remove(unsigned int cpu)
>> +static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
>> {
>> struct pdev_entry *p, *n;
>> mutex_lock(&pdev_list_mutex);
>>
>>
>>
>>
>
> I think the change in the coretemp.c is needed but other 2 are
> unnecessary because CONFIG_HOTPLUG_CPU has covered the codes final
> status after init done.
Perhaps you're right, but (just like was done for coretemp) these
CONFIG_HOTPLUG_CPU conditionals are really superfluous and should
go away.
Jan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] x86/hwmon: {core, pkg,
2010-09-14 7:35 ` [lm-sensors] [PATCH] x86/hwmon: {core,pkg,via-cpu}temp_device_remove() can all be __cpuinit Jan Beulich
@ 2010-09-14 7:46 ` Chen Gong
-1 siblings, 0 replies; 8+ messages in thread
From: Chen Gong @ 2010-09-14 7:46 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-kernel, lm-sensors
于 9/14/2010 3:35 PM, Jan Beulich 写道:
>>>> On 14.09.10 at 09:24, Chen Gong<gong.chen@linux.intel.com> wrote:
>> 于 9/13/2010 6:30 PM, Jan Beulich 写道:
>>> ... as they're being called only from a __cpuinit function.
>>>
>>> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>>>
>>> ---
>>> drivers/hwmon/coretemp.c | 2 +-
>>> drivers/hwmon/pkgtemp.c | 2 +-
>>> drivers/hwmon/via-cputemp.c | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> --- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000
>> +0200
>>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03
>> 17:54:14.000000000 +0200
>>> @@ -480,7 +480,7 @@ exit:
>>> return err;
>>> }
>>>
>>> -static void coretemp_device_remove(unsigned int cpu)
>>> +static void __cpuinit coretemp_device_remove(unsigned int cpu)
>>> {
>>> struct pdev_entry *p, *n;
>>> mutex_lock(&pdev_list_mutex);
>>> --- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000
>> +0200
>>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01
>> 09:00:45.000000000 +0200
>>> @@ -337,7 +337,7 @@ exit:
>>> }
>>>
>>> #ifdef CONFIG_HOTPLUG_CPU
>>> -static void pkgtemp_device_remove(unsigned int cpu)
>>> +static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
>>> {
>>> struct pdev_entry *p, *n;
>>> unsigned int i;
>>> --- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13
>> 08:45:03.000000000 +0200
>>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13
>> 00:00:00.000000000 +0200
>>> @@ -238,7 +238,7 @@ exit:
>>> }
>>>
>>> #ifdef CONFIG_HOTPLUG_CPU
>>> -static void via_cputemp_device_remove(unsigned int cpu)
>>> +static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
>>> {
>>> struct pdev_entry *p, *n;
>>> mutex_lock(&pdev_list_mutex);
>>>
>>>
>>>
>>>
>>
>> I think the change in the coretemp.c is needed but other 2 are
>> unnecessary because CONFIG_HOTPLUG_CPU has covered the codes final
>> status after init done.
>
> Perhaps you're right, but (just like was done for coretemp) these
> CONFIG_HOTPLUG_CPU conditionals are really superfluous and should
> go away.
>
> Jan
Agree. Maybe you can fix them in a uniform way
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [PATCH] x86/hwmon: {core, pkg, via-cpu}temp_device_remove() can all be __cpuinit
@ 2010-09-14 7:46 ` Chen Gong
0 siblings, 0 replies; 8+ messages in thread
From: Chen Gong @ 2010-09-14 7:46 UTC (permalink / raw)
To: Jan Beulich; +Cc: linux-kernel, lm-sensors
于 9/14/2010 3:35 PM, Jan Beulich 写道:
>>>> On 14.09.10 at 09:24, Chen Gong<gong.chen@linux.intel.com> wrote:
>> 于 9/13/2010 6:30 PM, Jan Beulich 写道:
>>> ... as they're being called only from a __cpuinit function.
>>>
>>> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>>>
>>> ---
>>> drivers/hwmon/coretemp.c | 2 +-
>>> drivers/hwmon/pkgtemp.c | 2 +-
>>> drivers/hwmon/via-cputemp.c | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> --- linux-2.6.36-rc4/drivers/hwmon/coretemp.c 2010-09-13 08:45:02.000000000
>> +0200
>>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/coretemp.c 2010-09-03
>> 17:54:14.000000000 +0200
>>> @@ -480,7 +480,7 @@ exit:
>>> return err;
>>> }
>>>
>>> -static void coretemp_device_remove(unsigned int cpu)
>>> +static void __cpuinit coretemp_device_remove(unsigned int cpu)
>>> {
>>> struct pdev_entry *p, *n;
>>> mutex_lock(&pdev_list_mutex);
>>> --- linux-2.6.36-rc4/drivers/hwmon/pkgtemp.c 2010-09-13 08:45:03.000000000
>> +0200
>>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/pkgtemp.c 2010-09-01
>> 09:00:45.000000000 +0200
>>> @@ -337,7 +337,7 @@ exit:
>>> }
>>>
>>> #ifdef CONFIG_HOTPLUG_CPU
>>> -static void pkgtemp_device_remove(unsigned int cpu)
>>> +static void __cpuinit pkgtemp_device_remove(unsigned int cpu)
>>> {
>>> struct pdev_entry *p, *n;
>>> unsigned int i;
>>> --- linux-2.6.36-rc4/drivers/hwmon/via-cputemp.c 2010-09-13
>> 08:45:03.000000000 +0200
>>> +++ 2.6.36-rc4-x86-hwmon-sections/drivers/hwmon/via-cputemp.c 2010-09-13
>> 00:00:00.000000000 +0200
>>> @@ -238,7 +238,7 @@ exit:
>>> }
>>>
>>> #ifdef CONFIG_HOTPLUG_CPU
>>> -static void via_cputemp_device_remove(unsigned int cpu)
>>> +static void __cpuinit via_cputemp_device_remove(unsigned int cpu)
>>> {
>>> struct pdev_entry *p, *n;
>>> mutex_lock(&pdev_list_mutex);
>>>
>>>
>>>
>>>
>>
>> I think the change in the coretemp.c is needed but other 2 are
>> unnecessary because CONFIG_HOTPLUG_CPU has covered the codes final
>> status after init done.
>
> Perhaps you're right, but (just like was done for coretemp) these
> CONFIG_HOTPLUG_CPU conditionals are really superfluous and should
> go away.
>
> Jan
Agree. Maybe you can fix them in a uniform way
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-09-14 7:46 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-13 10:30 [lm-sensors] [PATCH] x86/hwmon: {core, pkg, Jan Beulich
2010-09-13 10:30 ` [PATCH] x86/hwmon: {core,pkg,via-cpu}temp_device_remove() can all be __cpuinit Jan Beulich
2010-09-14 7:24 ` [lm-sensors] [PATCH] x86/hwmon: {core, pkg, Chen Gong
2010-09-14 7:24 ` [lm-sensors] [PATCH] x86/hwmon: {core, pkg, via-cpu}temp_device_remove() can all be __cpuinit Chen Gong
2010-09-14 7:35 ` [lm-sensors] [PATCH] x86/hwmon: {core, pkg, Jan Beulich
2010-09-14 7:35 ` [lm-sensors] [PATCH] x86/hwmon: {core,pkg,via-cpu}temp_device_remove() can all be __cpuinit Jan Beulich
2010-09-14 7:46 ` [lm-sensors] [PATCH] x86/hwmon: {core, pkg, Chen Gong
2010-09-14 7:46 ` [lm-sensors] [PATCH] x86/hwmon: {core, pkg, via-cpu}temp_device_remove() can all be __cpuinit Chen Gong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.