All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] RFC: v3: Support multiple STA on same AP with ath9k
Date: Tue, 14 Sep 2010 07:39:54 -0700	[thread overview]
Message-ID: <4C8F893A.8090203@candelatech.com> (raw)
In-Reply-To: <20100914134613.GB27234@vasanth-laptop>

On 09/14/2010 06:46 AM, Vasanthakumar Thiagarajan wrote:
> On Tue, Sep 14, 2010 at 12:53:29AM +0530, Ben Greear wrote:
>> Any suggestions for fixing the bssid mask setting in ath_opmode_init?
>> My change, appears to work because it's set in ath9k_add_interface, even
>> if not in the ath_opmode_init method.
>
> checking for ah->hw in ath_opmode_init() is buggy. bssid mask
> configuration from ath9k_add_interface() may not work well when
> some of the other vifs are in down state, may be this needs to
> be in ath_opmode_init() without that incorrect check.

It seems we need the ah->hw object to get the list of interfaces, but
ah->hw is NULL in ath_opmode_init.  Is there another way to get the
list of interfaces so we can iterate over them to build the ssid mask?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Vasanthakumar Thiagarajan <vasanth@Atheros.com>
Cc: Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"ath9k-devel@lists.ath9k.org" <ath9k-devel@venema.h4ckr.net>
Subject: Re: RFC:  v3: Support multiple STA on same AP with ath9k
Date: Tue, 14 Sep 2010 07:39:54 -0700	[thread overview]
Message-ID: <4C8F893A.8090203@candelatech.com> (raw)
In-Reply-To: <20100914134613.GB27234@vasanth-laptop>

On 09/14/2010 06:46 AM, Vasanthakumar Thiagarajan wrote:
> On Tue, Sep 14, 2010 at 12:53:29AM +0530, Ben Greear wrote:
>> Any suggestions for fixing the bssid mask setting in ath_opmode_init?
>> My change, appears to work because it's set in ath9k_add_interface, even
>> if not in the ath_opmode_init method.
>
> checking for ah->hw in ath_opmode_init() is buggy. bssid mask
> configuration from ath9k_add_interface() may not work well when
> some of the other vifs are in down state, may be this needs to
> be in ath_opmode_init() without that incorrect check.

It seems we need the ah->hw object to get the list of interfaces, but
ah->hw is NULL in ath_opmode_init.  Is there another way to get the
list of interfaces so we can iterate over them to build the ssid mask?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2010-09-14 14:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 20:07 [ath9k-devel] RFC: v3: Support multiple STA on same AP with ath9k Ben Greear
2010-09-10 20:07 ` Ben Greear
2010-09-10 21:12 ` [ath9k-devel] " Johannes Berg
2010-09-10 21:12   ` Johannes Berg
2010-09-10 21:23   ` [ath9k-devel] " Ben Greear
2010-09-10 21:23     ` Ben Greear
2010-09-10 21:27     ` [ath9k-devel] " Johannes Berg
2010-09-10 21:27       ` Johannes Berg
2010-09-13 12:14 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-09-13 12:14   ` Vasanthakumar Thiagarajan
2010-09-13 14:36   ` [ath9k-devel] " Ben Greear
2010-09-13 14:36     ` Ben Greear
2010-09-13 19:23   ` [ath9k-devel] " Ben Greear
2010-09-13 19:23     ` Ben Greear
2010-09-14 13:46     ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-09-14 13:46       ` Vasanthakumar Thiagarajan
2010-09-14 14:39       ` Ben Greear [this message]
2010-09-14 14:39         ` Ben Greear
2010-09-14 14:44         ` [ath9k-devel] " Vasanthakumar Thiagarajan
2010-09-14 14:44           ` Vasanthakumar Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8F893A.8090203@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.