phonesim fix for multiple proactive command ind

phonesim fix for multiple proactive command ind

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]


Hi,

 This patch fixes the multiple answering of AT+CSIM command and 
multiple notification of the new proactive command.

Regards,
jeevaka

[PATCH] phonesim: Fix multiple proactive command ind issue

[Jeevaka Badrappan]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

---
 src/phonesim.cpp |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/phonesim.cpp b/src/phonesim.cpp
index 8210f51..89089b2 100644
--- a/src/phonesim.cpp
+++ b/src/phonesim.cpp
@@ -1013,11 +1013,13 @@ bool SimRules::simCommand( const QString& cmd )
         QSimTerminalResponse resp =
             QSimTerminalResponse::fromPdu( param.mid(5) );
 
-        if ( toolkitApp->response( resp ) )
-            return simCsimOk( QByteArray() );
+        /* Incase of successful case, response is sent inside
+         * the SimApplication::response function. response function
+         * also handles the notification of new command
+         */
+        if ( !toolkitApp->response( resp ) )
+            respond( "+CSIM: 4,6F00\\n\\nOK" );
 
-        /* Response to the wrong type of command. */
-        respond( "+CSIM: 4,6F00\\n\\nOK" );
         return true;
     } else if ( param.length() >= 5 && param[1] == (char)0x2c &&
                     param[4] == (char)0x10 && param.size() >= 21 ) {
-- 
1.7.0.4

Re: [PATCH] phonesim: Fix multiple proactive command ind issue

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

Hi Jeevaka,

On 09/14/2010 11:22 AM, Jeevaka Badrappan wrote:
> ---
>  src/phonesim.cpp |   10 ++++++----
>  1 files changed, 6 insertions(+), 4 deletions(-)
> 

This patch has been applied, thanks.

Regards,
-Denis