All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Jim Meyering <jim@meyering.net>
Cc: hail-devel@vger.kernel.org
Subject: Re: [PATCH] don't expect inode name to be NUL-terminated (avoid read overrun)
Date: Tue, 14 Sep 2010 13:44:40 -0400	[thread overview]
Message-ID: <4C8FB488.1050605@garzik.org> (raw)
In-Reply-To: <874odxep0l.fsf@meyering.net>

On 09/10/2010 08:55 AM, Jim Meyering wrote:
>
> * server/msg.c (msg_get): Copy only name_len bytes, then NUL-terminate,
> rather than using snprintf to copy up to and including nonexistent NUL.
> ---
>
> valgrind exposed this.  The use of snprintf would have been
> correct if the inode name buffer (following the struct raw_inode)
> were NUL-terminated, but it is not.

applied -- good catch

out of curiosity, what is your patch base?

We combined cld and chunkd into a single 'hail' pkg, and from the 
pathname, your patch was generated from the older cld pkg.  We'd like to 
find the source and replace cld/chunkd with 'hail'.

F12?  F13?  rawhide?

Thanks,

	Jeff




  parent reply	other threads:[~2010-09-14 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-10 12:55 [PATCH] don't expect inode name to be NUL-terminated (avoid read overrun) Jim Meyering
2010-09-10 17:01 ` Colin McCabe
2010-09-14 17:44 ` Jeff Garzik [this message]
2010-09-15  8:15   ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C8FB488.1050605@garzik.org \
    --to=jeff@garzik.org \
    --cc=hail-devel@vger.kernel.org \
    --cc=jim@meyering.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.