From: Jim Meyering <jim@meyering.net>
To: Jeff Garzik <jeff@garzik.org>
Cc: hail-devel@vger.kernel.org
Subject: Re: [PATCH] don't expect inode name to be NUL-terminated (avoid read overrun)
Date: Wed, 15 Sep 2010 10:15:13 +0200 [thread overview]
Message-ID: <874odr2zji.fsf@meyering.net> (raw)
In-Reply-To: <4C8FB488.1050605@garzik.org> (Jeff Garzik's message of "Tue, 14 Sep 2010 13:44:40 -0400")
Jeff Garzik wrote:
> On 09/10/2010 08:55 AM, Jim Meyering wrote:
>>
>> * server/msg.c (msg_get): Copy only name_len bytes, then NUL-terminate,
>> rather than using snprintf to copy up to and including nonexistent NUL.
>> ---
>>
>> valgrind exposed this. The use of snprintf would have been
>> correct if the inode name buffer (following the struct raw_inode)
>> were NUL-terminated, but it is not.
>
> applied -- good catch
>
> out of curiosity, what is your patch base?
>
> We combined cld and chunkd into a single 'hail' pkg, and from the
> pathname, your patch was generated from the older cld pkg. We'd like
> to find the source and replace cld/chunkd with 'hail'.
>
> F12? F13? rawhide?
Hi Jeff,
I was using the sources from here:
git://git.kernel.org/pub/scm/daemon/cld/cld.git
From your comment there must be a hail git repository.
Found it:
http://git.kernel.org/?p=daemon/distsrv/hail.git;a=summary
FYI, when I searched for hail's git repository initially,
https://hail.wiki.kernel.org/ was inaccessible, so I found
the above in a presumably-old cache.
prev parent reply other threads:[~2010-09-15 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 12:55 [PATCH] don't expect inode name to be NUL-terminated (avoid read overrun) Jim Meyering
2010-09-10 17:01 ` Colin McCabe
2010-09-14 17:44 ` Jeff Garzik
2010-09-15 8:15 ` Jim Meyering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874odr2zji.fsf@meyering.net \
--to=jim@meyering.net \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.