From: Jeremy Fitzhardinge <jeremy@goop.org>
To: matt mooney <mfm@muteddisk.com>
Cc: xen-devel@lists.xensource.com,
Jeremy Fitzhardinge <jeremy@xensource.com>,
x86@kernel.org, kernel-janitors@vger.kernel.org,
Chris Wright <chrisw@sous-sol.org>,
virtualization@lists.osdl.org, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/4] x86: remove cast from void*
Date: Tue, 14 Sep 2010 17:49:55 +0000 [thread overview]
Message-ID: <4C8FB5C3.3050806@goop.org> (raw)
In-Reply-To: <1284441511-11511-1-git-send-email-mfm@muteddisk.com>
On 09/13/2010 10:18 PM, matt mooney wrote:
> Unnecessary cast from void* in assignment.
Not very keen on this. The cast may not be strictly required, but it
does document what's going on there.
J
> Signed-off-by: matt mooney <mfm@muteddisk.com>
> ---
> arch/x86/xen/mmu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 42086ac..7436283 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd)
>
> if (offset < pgd_index(USER_LIMIT)) {
> struct page *page = virt_to_page(pgd_page);
> - user_ptr = (pgd_t *)page->private;
> + user_ptr = page->private;
> if (user_ptr)
> user_ptr += offset;
> }
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: matt mooney <mfm@muteddisk.com>
Cc: xen-devel@lists.xensource.com,
Jeremy Fitzhardinge <jeremy@xensource.com>,
x86@kernel.org, kernel-janitors@vger.kernel.org,
Chris Wright <chrisw@sous-sol.org>,
virtualization@lists.osdl.org, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/4] x86: remove cast from void*
Date: Tue, 14 Sep 2010 10:49:55 -0700 [thread overview]
Message-ID: <4C8FB5C3.3050806@goop.org> (raw)
In-Reply-To: <1284441511-11511-1-git-send-email-mfm@muteddisk.com>
On 09/13/2010 10:18 PM, matt mooney wrote:
> Unnecessary cast from void* in assignment.
Not very keen on this. The cast may not be strictly required, but it
does document what's going on there.
J
> Signed-off-by: matt mooney <mfm@muteddisk.com>
> ---
> arch/x86/xen/mmu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 42086ac..7436283 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -737,7 +737,7 @@ pgd_t *xen_get_user_pgd(pgd_t *pgd)
>
> if (offset < pgd_index(USER_LIMIT)) {
> struct page *page = virt_to_page(pgd_page);
> - user_ptr = (pgd_t *)page->private;
> + user_ptr = page->private;
> if (user_ptr)
> user_ptr += offset;
> }
next prev parent reply other threads:[~2010-09-14 17:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 5:18 [PATCH 1/4] x86: remove cast from void* matt mooney
2010-09-14 5:18 ` matt mooney
2010-09-14 17:49 ` Jeremy Fitzhardinge [this message]
2010-09-14 17:49 ` Jeremy Fitzhardinge
2010-09-14 18:20 ` H. Peter Anvin
2010-09-14 18:20 ` H. Peter Anvin
2010-09-14 18:46 ` Jeremy Fitzhardinge
2010-09-14 18:46 ` Jeremy Fitzhardinge
2010-09-21 18:39 ` Jeremy Fitzhardinge
2010-09-21 18:39 ` Jeremy Fitzhardinge
2010-09-21 19:15 ` matt mooney
2010-09-21 19:15 ` matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8FB5C3.3050806@goop.org \
--to=jeremy@goop.org \
--cc=chrisw@sous-sol.org \
--cc=hpa@zytor.com \
--cc=ian.campbell@citrix.com \
--cc=jeremy@xensource.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=mfm@muteddisk.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=virtualization@lists.osdl.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.