All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Russell King <linux@arm.linux.org.uk>
Subject: Re: linux-next: build failure after merge of the final tree (tip tree related)
Date: Thu, 16 Sep 2010 00:20:36 -0700	[thread overview]
Message-ID: <4C91C544.5050907@kernel.org> (raw)
In-Reply-To: <20100916170939.22e38e4c.sfr@canb.auug.org.au>

From: Stephen Rothwell <sfr@canb.auug.org.au>

[PATCH] arm,memblock: Fix compiling with sparsemem

Stephen Rothwell found:

> > > arch/arm/mm/init.c: In function 'arm_memory_present':
> > > arch/arm/mm/init.c:260: warning: ISO C90 forbids mixed declarations and code
> > > arch/arm/mm/init.c:338: error: invalid storage class for function 'free_area'
> > > arch/arm/mm/init.c:357: error: invalid storage class for function 'free_memmap'
> > > arch/arm/mm/init.c:386: error: invalid storage class for function 'free_unused_memmap'
> > > arch/arm/mm/init.c:601: error: invalid storage class for function 'keepinitrd_setup'
> > > arch/arm/mm/init.c:606: error: initializer element is not constant
> > > arch/arm/mm/init.c:606: error: (near initialization for '__setup_keepinitrd_setup.setup_func')
> > > arch/arm/mm/init.c:606: error: expected declaration or statement at end of input
> > > arch/arm/mm/init.c:252: warning: unused variable 'i'
> > >
> > > Caused by commit 719c1514f2fef5f01fcfa2bba81b7bb079c7c6a1 ("memblock/arm:
> > > Use new accessors") which forgot a closing brace on a new
> > > for_each_memblock() in arm_memory_present().

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/arm/mm/init.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-2.6/arch/arm/mm/init.c
===================================================================
--- linux-2.6.orig/arch/arm/mm/init.c
+++ linux-2.6/arch/arm/mm/init.c
@@ -249,9 +249,8 @@ static void arm_memory_present(void)
 static void arm_memory_present(void)
 {
 	struct memblock_region *reg;
-	int i;
 
-	for_each_memblock(memory, reg) {
+	for_each_memblock(memory, reg)
 		memory_present(0, memblock_region_base_pfn(reg),
 			       memblock_region_end_pfn(reg));
 }

  reply	other threads:[~2010-09-16  7:23 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 14:29 linux-next: build failure after merge of the final tree (tip tree related) Stephen Rothwell
2010-09-16  6:32 ` Stephen Rothwell
2010-09-16  6:39   ` Ingo Molnar
2010-09-16  7:08     ` Russell King - ARM Linux
2010-09-16  7:34       ` Ingo Molnar
2010-09-16  9:02         ` Russell King - ARM Linux
2010-09-16  7:09     ` Stephen Rothwell
2010-09-16  7:20       ` Yinghai Lu [this message]
2010-09-16  7:27         ` Stephen Rothwell
2010-09-16 14:43         ` [tip:core/memblock] arm, memblock: Fix the sparsemem build tip-bot for Yinghai Lu
  -- strict thread matches above, loose matches on Subject: below --
2011-04-12  4:00 linux-next: build failure after merge of the final tree (tip tree related) Stephen Rothwell
2011-04-12  6:20 ` Ingo Molnar
2011-04-12  6:25   ` David Miller
2010-11-29  2:50 Stephen Rothwell
2010-11-29 22:30 ` Peter Zijlstra
2010-12-07  1:56 ` Stephen Rothwell
2010-11-22  2:39 Stephen Rothwell
2010-11-22 22:00 ` Don Zickus
2010-11-29  2:50 ` Stephen Rothwell
2010-11-29  8:29   ` Ingo Molnar
2010-11-29 14:30     ` Don Zickus
2010-12-07  1:58       ` Stephen Rothwell
2010-12-07 15:37         ` Don Zickus
2010-10-14  5:49 Stephen Rothwell
2010-10-14  6:31 ` Ingo Molnar
2010-09-13 14:06 Stephen Rothwell
2010-09-13 19:17 ` Matt Fleming
2010-09-13 19:22   ` Peter Zijlstra
2010-08-02 16:23 Stephen Rothwell
2010-08-02 16:28 ` Russell King
2010-08-02 16:32   ` H. Peter Anvin
2010-08-03  1:07     ` Benjamin Herrenschmidt
2010-08-03  1:42   ` Benjamin Herrenschmidt
2010-08-03  3:13     ` H. Peter Anvin
2010-08-03  4:32       ` Benjamin Herrenschmidt
2010-08-03  5:29     ` Ingo Molnar
2010-08-02 16:28 ` Stephen Rothwell
2010-08-03  1:41 ` Benjamin Herrenschmidt
2010-06-23 16:31 Stephen Rothwell
2010-06-23 16:55 ` Frederic Weisbecker
2010-06-23 23:31   ` Stephen Rothwell
2010-06-24  0:37     ` Stephen Rothwell
2010-06-23  0:50 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C91C544.5050907@kernel.org \
    --to=yinghai@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.