All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: HDA: Enable internal speaker on Dell M101z
@ 2010-09-16  8:16 David Henningsson
  2010-09-16  8:20 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: David Henningsson @ 2010-09-16  8:16 UTC (permalink / raw)
  To: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

BugLink: http://launchpad.net/bugs/640254

In some cases a magic processing coefficient is needed to enable
the internal speaker on Dell M101z. According to Realtek, this
processing coefficient is only present on ALC269vb.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

[-- Attachment #2: 0001-ALSA-HDA-Enable-internal-speaker-on-Dell-M101z.patch --]
[-- Type: text/x-patch, Size: 1616 bytes --]

>From 363739d6b5eefb44a0cbbf44c390f8fcd01a6e58 Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Thu, 16 Sep 2010 10:07:53 +0200
Subject: [PATCH] ALSA: HDA: Enable internal speaker on Dell M101z

BugLink: http://launchpad.net/bugs/640254

In some cases a magic processing coefficient is needed to enable
the internal speaker on Dell M101z. According to Realtek, this
processing coefficient is only present on ALC269vb.

Cc: stable@kernel.org
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_realtek.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index ab2947d..2063d0f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -14671,6 +14671,7 @@ static int alc269_resume(struct hda_codec *codec)
 
 enum {
 	ALC269_FIXUP_SONY_VAIO,
+	ALC269_FIXUP_DELL_M101Z,
 };
 
 static const struct alc_fixup alc269_fixups[] = {
@@ -14680,11 +14681,20 @@ static const struct alc_fixup alc269_fixups[] = {
 			{}
 		}
 	},
+	[ALC269_FIXUP_DELL_M101Z] = {
+		.verbs = (const struct hda_verb[]) {
+			/* Enables internal speaker */
+			{0x20, AC_VERB_SET_COEF_INDEX, 13},
+			{0x20, AC_VERB_SET_PROC_COEF, 0x4040},
+			{}
+		}
+	},
 };
 
 static struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x104d, 0x9071, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
 	SND_PCI_QUIRK(0x104d, 0x9077, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
+	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
 	{}
 };
 
-- 
1.7.1


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ALSA: HDA: Enable internal speaker on Dell M101z
  2010-09-16  8:16 [PATCH] ALSA: HDA: Enable internal speaker on Dell M101z David Henningsson
@ 2010-09-16  8:20 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-09-16  8:20 UTC (permalink / raw)
  To: David Henningsson; +Cc: alsa-devel

At Thu, 16 Sep 2010 10:16:10 +0200,
David Henningsson wrote:
> 
> BugLink: http://launchpad.net/bugs/640254
> 
> In some cases a magic processing coefficient is needed to enable
> the internal speaker on Dell M101z. According to Realtek, this
> processing coefficient is only present on ALC269vb.
> 
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>

ALC269v codecs have really magic sequences.  Recently another magic
COEF stuff was merged, too :)

Applied now.  Thanks.


Takashi


> 
> -- 
> David Henningsson, Canonical Ltd.
> http://launchpad.net/~diwic
> [2 0001-ALSA-HDA-Enable-internal-speaker-on-Dell-M101z.patch <text/x-patch (7bit)>]
> >From 363739d6b5eefb44a0cbbf44c390f8fcd01a6e58 Mon Sep 17 00:00:00 2001
> From: David Henningsson <david.henningsson@canonical.com>
> Date: Thu, 16 Sep 2010 10:07:53 +0200
> Subject: [PATCH] ALSA: HDA: Enable internal speaker on Dell M101z
> 
> BugLink: http://launchpad.net/bugs/640254
> 
> In some cases a magic processing coefficient is needed to enable
> the internal speaker on Dell M101z. According to Realtek, this
> processing coefficient is only present on ALC269vb.
> 
> Cc: stable@kernel.org
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ab2947d..2063d0f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -14671,6 +14671,7 @@ static int alc269_resume(struct hda_codec *codec)
>  
>  enum {
>  	ALC269_FIXUP_SONY_VAIO,
> +	ALC269_FIXUP_DELL_M101Z,
>  };
>  
>  static const struct alc_fixup alc269_fixups[] = {
> @@ -14680,11 +14681,20 @@ static const struct alc_fixup alc269_fixups[] = {
>  			{}
>  		}
>  	},
> +	[ALC269_FIXUP_DELL_M101Z] = {
> +		.verbs = (const struct hda_verb[]) {
> +			/* Enables internal speaker */
> +			{0x20, AC_VERB_SET_COEF_INDEX, 13},
> +			{0x20, AC_VERB_SET_PROC_COEF, 0x4040},
> +			{}
> +		}
> +	},
>  };
>  
>  static struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x104d, 0x9071, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
>  	SND_PCI_QUIRK(0x104d, 0x9077, "Sony VAIO", ALC269_FIXUP_SONY_VAIO),
> +	SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z),
>  	{}
>  };
>  
> -- 
> 1.7.1
> 
> [3  <text/plain; us-ascii (7bit)>]
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-09-16  8:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-16  8:16 [PATCH] ALSA: HDA: Enable internal speaker on Dell M101z David Henningsson
2010-09-16  8:20 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.