Re: [mac80211] mac80211: Support receiving data frames on multiple vifs.

[Ben Greear <greearb@candelatech.com>]

On 09/20/2010 12:10 PM, Johannes Berg wrote:
> On Mon, 2010-09-20 at 10:52 -0700, greearb@candelatech.com wrote:
>> From: Ben Greear<greearb@candelatech.com>
>>
>> When using multiple STA interfaces on the same radio, some
>> data packets need to be received on all interfaces
>> (broadcast, for instance).
>>
>> Remove special loop for data-only packets and just process all
>> packets in the big loop that previously only handled non-data
>> packets.
>
> I'd prefer keeping different for_each_*, but maybe we can make the loops
> just call a common function, say with&prev pointer or something? The
> station loop will typically be iterating over fewer things here.

While attempting this, I see something strange.  It appears that
for the last interface (in the non-data loop), the
if (status->flag & RX_FLAG_MMIC_ERROR)
logic will not be run?

Is that on purpose?

Thanks,
Ben

>
> johannes


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com