From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [mac80211] mac80211: Support receiving data frames on multiple vifs.
Date: Thu, 23 Sep 2010 11:48:14 -0700 [thread overview]
Message-ID: <4C9BA0EE.9090206@candelatech.com> (raw)
In-Reply-To: <1285267335.3770.400.camel@jlt3.sipsolutions.net>
On 09/23/2010 11:42 AM, Johannes Berg wrote:
> On Thu, 2010-09-23 at 09:57 -0700, Ben Greear wrote:
>
>>> Well, I personally would've tried to reduce the code duplication between
>>> the two loops, but right now I'm not sure I see how to.
>>
>> I could move some of the rx setup code into prepare_for_handlers,
>> but not sure how much that would help readability.
>>
>> In my opinion, that would be a good candidate for a followup
>> patch instead of adding that to this patch, though.
>
> Yeah, I can agree with that.
>
> I have a patch that also touches this area, I'll let you get this one in
> first and rebase it.
Thanks!
I'm currently testing VAP + STA on same hardware concurrently with
ath5k, and seems the VAP doesn't receive any packets.
When I get that sorted, I'll work on the rx setup code minimization
patch.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2010-09-23 18:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 21:39 [mac80211] mac80211: Support receiving data frames on multiple vifs greearb
2010-09-21 6:47 ` Johannes Berg
2010-09-23 13:57 ` Ben Greear
2010-09-23 14:06 ` Johannes Berg
2010-09-23 16:57 ` Ben Greear
2010-09-23 18:42 ` Johannes Berg
2010-09-23 18:48 ` Ben Greear [this message]
2010-09-23 19:07 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2010-09-20 17:52 greearb
2010-09-20 19:10 ` Johannes Berg
2010-09-20 19:56 ` Ben Greear
2010-09-21 6:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9BA0EE.9090206@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.