Re: [RFC] base.bbclass: add make-native to default dependencies

[Michael Smith <msmith@cbnco.com>]

Khem Raj wrote:
> On Tue, Sep 21, 2010 at 6:58 AM, Michael Smith <msmith@cbnco.com> wrote:
>> Khem Raj wrote:
>>
>>> although it does but make 3.82 is not usable out of box yet.
>>> so people might find surprises. 3.81 would be ok.
> 
> I hit eglibc there may be more.

Hmm, OK. The patch below wouldn't affect eglibc's dependencies, so we'd 
still have to change eglibc.inc and eglibc-initial.inc to depend on 
make-native, or people with make 3.82 on their host system will be 
unable to build eglibc.

Or, apply a patch to every version of eglibc to fix the build with make 
3.82.

Which do you prefer? I can only really test glibc 2.9, but adding 
make-native to the DEPENDS in glibc.inc/glibc-initial.inc should work 
about the same as doing it in eglibc.

Mike

>>>> diff --git a/classes/base.bbclass b/classes/base.bbclass
>>>> index b19eb32..5c6d41d 100644
>>>> --- a/classes/base.bbclass
>>>> +++ b/classes/base.bbclass
>>>> @@ -71,7 +71,7 @@ def base_deps(d):
>>>>       if not bb.data.getVar('INHIBIT_DEFAULT_DEPS', d):
>>>>               if (bb.data.getVar('HOST_SYS', d, 1) !=
>>>>                   bb.data.getVar('BUILD_SYS', d, 1)):
>>>> -                       deps += " virtual/${TARGET_PREFIX}gcc
>>>> virtual/libc "
>>>> +                       deps += " make-native virtual/${TARGET_PREFIX}gcc
>>>> virtual/libc "
>>>>               elif bb.data.inherits_class('native', d) and \
>>>>                               bb.data.getVar('PN', d, True) not in \
>>>>                               ("linux-libc-headers-native",
>>>> "quilt-native",