* [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
@ 2010-09-19 21:59 Björn Krombholz
2010-09-19 22:51 ` Holger Freyther
0 siblings, 1 reply; 7+ messages in thread
From: Björn Krombholz @ 2010-09-19 21:59 UTC (permalink / raw)
To: openembedded-devel
* qt4e.bbclass did add a dependency on qt4-embedded for recipes
providing qt4-embedded. This breaks building of qt4-embedded-gles
in 2 ways:
1. PREFERRED_PROVIDER_qt4-embedded = qt4-embedded-gles
adds a circular dependency.
2. bitbake qt4-embedded-gles
first builds and installs qt4-embedded to sysroots/ and then
fails to link the qt4-embedded-gles build against the libs in
sysroots which don't provide the gl specific symbols
* The fix avoids adding the dependency for package names _beginning_
with 'qt4-embedded' (as it is done in the x11 version).
---
classes/qt4e.bbclass | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/classes/qt4e.bbclass b/classes/qt4e.bbclass
index f72e06b..303b79b 100644
--- a/classes/qt4e.bbclass
+++ b/classes/qt4e.bbclass
@@ -1,4 +1,4 @@
-DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1) == 'qt4-embedded')]}"
+DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1)[:12] == 'qt4-embedded')]}"
inherit qmake2
QT_DIR_NAME = "qtopia"
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
2010-09-19 21:59 [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded Björn Krombholz
@ 2010-09-19 22:51 ` Holger Freyther
2010-09-20 18:16 ` Björn Krombholz
0 siblings, 1 reply; 7+ messages in thread
From: Holger Freyther @ 2010-09-19 22:51 UTC (permalink / raw)
To: openembedded-devel
On 09/20/2010 05:59 AM, Björn Krombholz wrote:
=
> @@ -1,4 +1,4 @@
> -DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1) == 'qt4-embedded')]}"
> +DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1)[:12] == 'qt4-embedded')]}"
> inherit qmake2
use startsWith and avoid the extra array allocation?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
2010-09-19 22:51 ` Holger Freyther
@ 2010-09-20 18:16 ` Björn Krombholz
2010-09-21 9:18 ` Hauser, Wolfgang (external)
2010-09-21 17:29 ` Holger Freyther
0 siblings, 2 replies; 7+ messages in thread
From: Björn Krombholz @ 2010-09-20 18:16 UTC (permalink / raw)
To: openembedded-devel
2010/9/20 Holger Freyther <holger+oe@freyther.de>
> On 09/20/2010 05:59 AM, Björn Krombholz wrote:
> > @@ -1,4 +1,4 @@
> > -DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1) == 'qt4-embedded')]}"
> > +DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1)[:12] == 'qt4-embedded')]}"
> > inherit qmake2
>
> use startsWith and avoid the extra array allocation?
Array slicing just provides a new mapping onto the original array and
doesn't copy any data.
I chose this syntax to make it consistent with qt4x11.bbclass
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
2010-09-20 18:16 ` Björn Krombholz
@ 2010-09-21 9:18 ` Hauser, Wolfgang (external)
2010-09-21 11:51 ` Frans Meulenbroeks
2010-09-21 13:14 ` Koen Kooi
2010-09-21 17:29 ` Holger Freyther
1 sibling, 2 replies; 7+ messages in thread
From: Hauser, Wolfgang (external) @ 2010-09-21 9:18 UTC (permalink / raw)
To: openembedded-devel
Is it possible to apply this patch soon ? I need the gles version of qt4-embedded. At the time I workaround this problem by a modified qt4-embedded recipe.
-----Ursprüngliche Nachricht-----
Von: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] Im Auftrag von Björn Krombholz
Gesendet: Montag, 20. September 2010 20:16
An: openembedded-devel@lists.openembedded.org
Betreff: Re: [oe] [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
2010/9/20 Holger Freyther <holger+oe@freyther.de>
> On 09/20/2010 05:59 AM, Björn Krombholz wrote:
> > @@ -1,4 +1,4 @@
> > -DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1) == 'qt4-embedded')]}"
> > +DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1)[:12] == 'qt4-embedded')]}"
> > inherit qmake2
>
> use startsWith and avoid the extra array allocation?
Array slicing just provides a new mapping onto the original array and
doesn't copy any data.
I chose this syntax to make it consistent with qt4x11.bbclass
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
2010-09-21 9:18 ` Hauser, Wolfgang (external)
@ 2010-09-21 11:51 ` Frans Meulenbroeks
2010-09-21 13:14 ` Koen Kooi
1 sibling, 0 replies; 7+ messages in thread
From: Frans Meulenbroeks @ 2010-09-21 11:51 UTC (permalink / raw)
To: openembedded-devel
2010/9/21 Hauser, Wolfgang (external) <Wolfgang.Hauser.external@cassidian.com>:
> Is it possible to apply this patch soon ? I need the gles version of qt4-embedded. At the time I workaround this problem by a modified qt4-embedded recipe.
Can't judge the details of your patch (and can't push from here anyway).
What I normally do in those cases is keep the patched recipe in an
overlay (and discard it when the patch is applied).
Frans
>
> -----Ursprüngliche Nachricht-----
> Von: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] Im Auftrag von Björn Krombholz
> Gesendet: Montag, 20. September 2010 20:16
> An: openembedded-devel@lists.openembedded.org
> Betreff: Re: [oe] [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
>
> 2010/9/20 Holger Freyther <holger+oe@freyther.de>
>> On 09/20/2010 05:59 AM, Björn Krombholz wrote:
>> > @@ -1,4 +1,4 @@
>> > -DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1) == 'qt4-embedded')]}"
>> > +DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1)[:12] == 'qt4-embedded')]}"
>> > inherit qmake2
>>
>> use startsWith and avoid the extra array allocation?
>
> Array slicing just provides a new mapping onto the original array and
> doesn't copy any data.
>
> I chose this syntax to make it consistent with qt4x11.bbclass
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
2010-09-21 9:18 ` Hauser, Wolfgang (external)
2010-09-21 11:51 ` Frans Meulenbroeks
@ 2010-09-21 13:14 ` Koen Kooi
1 sibling, 0 replies; 7+ messages in thread
From: Koen Kooi @ 2010-09-21 13:14 UTC (permalink / raw)
To: openembedded-devel
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
It was applied yesterday already:
http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=224e98468078e9267b0b4c2d72bfb0eb3b2863ec
On 21-09-10 11:18, Hauser, Wolfgang (external) wrote:
> Is it possible to apply this patch soon ? I need the gles version of qt4-embedded. At the time I workaround this problem by a modified qt4-embedded recipe.
>
> -----Ursprüngliche Nachricht-----
> Von: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] Im Auftrag von Björn Krombholz
> Gesendet: Montag, 20. September 2010 20:16
> An: openembedded-devel@lists.openembedded.org
> Betreff: Re: [oe] [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
>
> 2010/9/20 Holger Freyther <holger+oe@freyther.de>
>> On 09/20/2010 05:59 AM, Björn Krombholz wrote:
>>> @@ -1,4 +1,4 @@
>>> -DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1) == 'qt4-embedded')]}"
>>> +DEPENDS_prepend = "${@["qt4-embedded ", ""][(bb.data.getVar('PN', d, 1)[:12] == 'qt4-embedded')]}"
>>> inherit qmake2
>>
>> use startsWith and avoid the extra array allocation?
>
> Array slicing just provides a new mapping onto the original array and
> doesn't copy any data.
>
> I chose this syntax to make it consistent with qt4x11.bbclass
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFMmK/SMkyGM64RGpERAt+6AJ90NQAJvd/iJCE7hr35N54LvvzVAQCfVkqr
ePDrcvS2KaENyo6CzPgnd9I=
=uqo0
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded
2010-09-20 18:16 ` Björn Krombholz
2010-09-21 9:18 ` Hauser, Wolfgang (external)
@ 2010-09-21 17:29 ` Holger Freyther
1 sibling, 0 replies; 7+ messages in thread
From: Holger Freyther @ 2010-09-21 17:29 UTC (permalink / raw)
To: openembedded-devel
On 09/21/2010 02:16 AM, Björn Krombholz wrote:
>> use startsWith and avoid the extra array allocation?
>
> Array slicing just provides a new mapping onto the original array and
> doesn't copy any data.
>
> I chose this syntax to make it consistent with qt4x11.bbclass
Well, it creates a new object, and you need to count things by hand (even if
humans have hands they tend to fail on that). Using the starts with function
is safer and avoid creating extra objects. :)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-09-21 17:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-19 21:59 [PATCH] qt4-embedded: avoid circular dependencies for reciped providing qt4-embedded Björn Krombholz
2010-09-19 22:51 ` Holger Freyther
2010-09-20 18:16 ` Björn Krombholz
2010-09-21 9:18 ` Hauser, Wolfgang (external)
2010-09-21 11:51 ` Frans Meulenbroeks
2010-09-21 13:14 ` Koen Kooi
2010-09-21 17:29 ` Holger Freyther
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.