[PATCH] utility-tasks.bbclass: drop mrproper task

[PATCH] utility-tasks.bbclass: drop mrproper task

[Chris Larson]

From: Chris Larson <chris_larson@mentor.com>

This task is misleading and potentially quite harmful, as it wipes the entire
DL_DIR, yet tasks are supposed to be recipe specific.  We have the proper
distclean task to wipe sources for a recipe + run do_clean, and the user can
always wipe all of DL_DIR manually if necessary.

Signed-off-by: Chris Larson <chris_larson@mentor.com>
---
 classes/utility-tasks.bbclass |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/classes/utility-tasks.bbclass b/classes/utility-tasks.bbclass
index 29bc781..7495d96 100644
--- a/classes/utility-tasks.bbclass
+++ b/classes/utility-tasks.bbclass
@@ -38,18 +38,6 @@ python do_rebuild() {
 	"""rebuild a package"""
 }
 
-addtask mrproper
-do_mrproper[dirs] = "${TOPDIR}"
-do_mrproper[nostamp] = "1"
-python do_mrproper() {
-	"""clear downloaded sources, build and temp directories"""
-	dir = bb.data.expand("${DL_DIR}", d)
-	if dir == '/': bb.build.FuncFailed("wrong DATADIR")
-	bb.debug(2, "removing " + dir)
-	os.system('rm -rf ' + dir)
-	bb.build.exec_func('do_clean', d)
-}
-
 addtask distclean
 do_distclean[dirs] = "${TOPDIR}"
 do_distclean[nostamp] = "1"
-- 
1.7.2.3

Re: [PATCH] utility-tasks.bbclass: drop mrproper task

[Holger Freyther]

On 09/21/2010 11:06 PM, Chris Larson wrote:
> From: Chris Larson <chris_larson@mentor.com>
> 
> This task is misleading and potentially quite harmful, as it wipes the entire
> DL_DIR, yet tasks are supposed to be recipe specific.  We have the proper
> distclean task to wipe sources for a recipe + run do_clean, and the user can
> always wipe all of DL_DIR manually if necessary.
> 
> Signed-off-by: Chris Larson <chris_larson@mentor.com>

Acked-by: Holger Hans Peter Freyther <holger@moiji-mobile.com>

Re: [PATCH] utility-tasks.bbclass: drop mrproper task

[Eric Bénard]

Le 21/09/2010 19:35, Holger Freyther a écrit :
> On 09/21/2010 11:06 PM, Chris Larson wrote:
>> From: Chris Larson<chris_larson@mentor.com>
>>
>> This task is misleading and potentially quite harmful, as it wipes the entire
>> DL_DIR, yet tasks are supposed to be recipe specific.  We have the proper
>> distclean task to wipe sources for a recipe + run do_clean, and the user can
>> always wipe all of DL_DIR manually if necessary.
>>
>> Signed-off-by: Chris Larson <chris_larson@mentor.com>
>
> Acked-by: Holger Hans Peter Freyther <holger@moiji-mobile.com>

Acked-by: Eric Bénard <eric@eukrea.com>