[PATCH] u-boot-env.bb: Mark as COMPATIBLE_MACHINE=neuros-osd2.

[PATCH] u-boot-env.bb: Mark as COMPATIBLE_MACHINE=neuros-osd2.

[Graham Gower]

Signed-off-by: Graham Gower <graham.gower@gmail.com>
---
 recipes/u-boot/u-boot-env.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/recipes/u-boot/u-boot-env.bb b/recipes/u-boot/u-boot-env.bb
index 1bee272..35c467b 100644
--- a/recipes/u-boot/u-boot-env.bb
+++ b/recipes/u-boot/u-boot-env.bb
@@ -4,6 +4,7 @@ PR = "r1"
 
 inherit kernel-arch
 
+COMPATIBLE_MACHINE = "(neuros-osd2)"
 SRC_URI = "file://default-env.ascr"
 
 
-- 
1.7.1

Re: [PATCH] u-boot-env.bb: Mark as COMPATIBLE_MACHINE=neuros-osd2.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 22-09-10 02:01, Graham Gower wrote:
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
> ---
>  recipes/u-boot/u-boot-env.bb |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/recipes/u-boot/u-boot-env.bb b/recipes/u-boot/u-boot-env.bb
> index 1bee272..35c467b 100644
> --- a/recipes/u-boot/u-boot-env.bb
> +++ b/recipes/u-boot/u-boot-env.bb
> @@ -4,6 +4,7 @@ PR = "r1"
>  
>  inherit kernel-arch
>  
> +COMPATIBLE_MACHINE = "(neuros-osd2)"
>  SRC_URI = "file://default-env.ascr"

NAK, the proper fix is to have a u-boot-env/default-env.ascr file as
fallback, not mark it as compatible_machine.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD4DBQFMmbcqMkyGM64RGpERAn34AJY9DA+/f3BMvKlUPBguyvW5GFr7AKCBTD3f
YuOzKiewU2PMBnI/uRn/QQ==
=m9S7
-----END PGP SIGNATURE-----

Re: [PATCH] u-boot-env.bb: Mark as COMPATIBLE_MACHINE=neuros-osd2.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

Dear Graham,


Am Mittwoch, den 22.09.2010, 09:31 +0930 schrieb Graham Gower:

it would be great if you could document what problem this fixes as
requested by the commit policy [1].

I am sorry if this change is trivial, but I do not know what it is for.

> Signed-off-by: Graham Gower <graham.gower@gmail.com>

[…]


Thanks,

Paul


[1] http://wiki.openembedded.net/index.php/Commit_Policy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] u-boot-env.bb: Mark as COMPATIBLE_MACHINE=neuros-osd2.

[Graham Gower]

This recipe fails to build for all machines except neuros-osd2.