[PATCH] mythfront-config.bb: Fix do_unpack for machines other than epia.

[PATCH] mythfront-config.bb: Fix do_unpack for machines other than epia.

[Graham Gower]

Signed-off-by: Graham Gower <graham.gower@gmail.com>
---
 recipes/mythfront/mythfront-config.bb |   14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/recipes/mythfront/mythfront-config.bb b/recipes/mythfront/mythfront-config.bb
index b87e0be..79ba428 100644
--- a/recipes/mythfront/mythfront-config.bb
+++ b/recipes/mythfront/mythfront-config.bb
@@ -1,11 +1,12 @@
 PV = "1.10"
-PR = "r0"
+PR = "r1"
 
 RDEPENDS_${PN} = "font-misc-misc"
 LICENSE = "MIT"
-SRC_URI = "file://tftp.sh file://xorg.conf"
+SRC_URI = "file://tftp.sh"
 
-SRC_URI_append_epia = " file://serial.sh"
+SRC_URI_append_epia = " file://serial.sh \
+			file://xorg.conf"
 
 do_install() {
 	install -d ${D}${sysconfdir}/udhcpc.d/
@@ -14,9 +15,6 @@ do_install() {
 	install -d ${D}${sysconfdir}/mythtv
 	ln -sf /var/lib/config/mysql.txt ${D}${sysconfdir}/mythtv
 
-	install -d ${D}${sysconfdir}/X11
-	install -m 0644 ${WORKDIR}/xorg.conf ${D}${sysconfdir}/X11
-
 	ln -sf /var/lib/config/lircd.conf ${D}${sysconfdir}/lircd.conf
 
 	install -d ${D}/dev
@@ -30,3 +28,7 @@ do_install() {
 	fi
 }
 
+do_install_append_epia() {
+	install -d ${D}${sysconfdir}/X11
+	install -m 0644 ${WORKDIR}/xorg.conf ${D}${sysconfdir}/X11
+}
-- 
1.7.1

Re: [PATCH] mythfront-config.bb: Fix do_unpack for machines other than epia.

[Frans Meulenbroeks]

2010/9/22 Graham Gower <graham.gower@gmail.com>:
> Signed-off-by: Graham Gower <graham.gower@gmail.com>
> ---
>  recipes/mythfront/mythfront-config.bb |   14 ++++++++------
>  1 files changed, 8 insertions(+), 6 deletions(-)
>
Thanks for unbreaking this.
I've never noticed this, but I must say I didn't really peek into this one.

Some concerns wrt the rest of the recipe though

> diff --git a/recipes/mythfront/mythfront-config.bb b/recipes/mythfront/mythfront-config.bb
> index b87e0be..79ba428 100644
> --- a/recipes/mythfront/mythfront-config.bb
> +++ b/recipes/mythfront/mythfront-config.bb
> @@ -1,11 +1,12 @@
>  PV = "1.10"
> -PR = "r0"
> +PR = "r1"
>
>  RDEPENDS_${PN} = "font-misc-misc"

This is not sufficient. There should also be a dependency on mythtv
itself and on lirc (but maybe mythtv will drag than one in)

>  LICENSE = "MIT"
> -SRC_URI = "file://tftp.sh file://xorg.conf"
> +SRC_URI = "file://tftp.sh"
>
> -SRC_URI_append_epia = " file://serial.sh"
> +SRC_URI_append_epia = " file://serial.sh \
> +                       file://xorg.conf"
>
>  do_install() {
>        install -d ${D}${sysconfdir}/udhcpc.d/
> @@ -14,9 +15,6 @@ do_install() {
>        install -d ${D}${sysconfdir}/mythtv
>        ln -sf /var/lib/config/mysql.txt ${D}${sysconfdir}/mythtv

This is already done if you install mythtv-database
>
> -       install -d ${D}${sysconfdir}/X11
> -       install -m 0644 ${WORKDIR}/xorg.conf ${D}${sysconfdir}/X11

Not sure if this is good. for epia there is an xorg.conf, but it is
not in the SRC_URIL for non-epia, so it cannot be installed for these
(unless you get it from somewhere else)

> -
>        ln -sf /var/lib/config/lircd.conf ${D}${sysconfdir}/lircd.conf

and i would say lirc should perhaps do this.
>
>        install -d ${D}/dev
> @@ -30,3 +28,7 @@ do_install() {
>        fi
>  }
>
> +do_install_append_epia() {
> +       install -d ${D}${sysconfdir}/X11
> +       install -m 0644 ${WORKDIR}/xorg.conf ${D}${sysconfdir}/X11
> +}
> --

Enjoy, Frans.

Re: [PATCH] mythfront-config.bb: Fix do_unpack for machines other than epia.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2673 bytes --]

Am Freitag, den 24.09.2010, 09:24 +0200 schrieb Frans Meulenbroeks:
> 2010/9/22 Graham Gower <graham.gower@gmail.com>:
> > Signed-off-by: Graham Gower <graham.gower@gmail.com>
> > ---
> >  recipes/mythfront/mythfront-config.bb |   14 ++++++++------
> >  1 files changed, 8 insertions(+), 6 deletions(-)
> >
> Thanks for unbreaking this.
> I've never noticed this, but I must say I didn't really peek into this one.
> 
> Some concerns wrt the rest of the recipe though
> 
> > diff --git a/recipes/mythfront/mythfront-config.bb b/recipes/mythfront/mythfront-config.bb
> > index b87e0be..79ba428 100644
> > --- a/recipes/mythfront/mythfront-config.bb
> > +++ b/recipes/mythfront/mythfront-config.bb
> > @@ -1,11 +1,12 @@
> >  PV = "1.10"
> > -PR = "r0"
> > +PR = "r1"
> >
> >  RDEPENDS_${PN} = "font-misc-misc"
> 
> This is not sufficient. There should also be a dependency on mythtv
> itself and on lirc (but maybe mythtv will drag than one in)
> 
> >  LICENSE = "MIT"
> > -SRC_URI = "file://tftp.sh file://xorg.conf"
> > +SRC_URI = "file://tftp.sh"
> >
> > -SRC_URI_append_epia = " file://serial.sh"
> > +SRC_URI_append_epia = " file://serial.sh \
> > +                       file://xorg.conf"
> >
> >  do_install() {
> >        install -d ${D}${sysconfdir}/udhcpc.d/
> > @@ -14,9 +15,6 @@ do_install() {
> >        install -d ${D}${sysconfdir}/mythtv
> >        ln -sf /var/lib/config/mysql.txt ${D}${sysconfdir}/mythtv
> 
> This is already done if you install mythtv-database
> >
> > -       install -d ${D}${sysconfdir}/X11
> > -       install -m 0644 ${WORKDIR}/xorg.conf ${D}${sysconfdir}/X11
> 
> Not sure if this is good. for epia there is an xorg.conf, but it is
> not in the SRC_URIL for non-epia, so it cannot be installed for these
> (unless you get it from somewhere else)

As far as I can see, this problem is the actual purpose of Graham’s
patch. It moves these commands to `do_install_append_epia()`.

> > -
> >        ln -sf /var/lib/config/lircd.conf ${D}${sysconfdir}/lircd.conf
> 
> and i would say lirc should perhaps do this.
> >
> >        install -d ${D}/dev
> > @@ -30,3 +28,7 @@ do_install() {
> >        fi
> >  }
> >
> > +do_install_append_epia() {
> > +       install -d ${D}${sysconfdir}/X11
> > +       install -m 0644 ${WORKDIR}/xorg.conf ${D}${sysconfdir}/X11
> > +}
> > --

Adhering to the mantra of small changes, I would acknowledge this patch
and get your concerns addressed in another patch. Frans, as one of the
MythTV maintainers, your Acked-by would be appreciated too, I guess.

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] mythfront-config.bb: Fix do_unpack for machines other than epia.

[Frans Meulenbroeks]

2010/9/24 Paul Menzel <paulepanter@users.sourceforge.net>:

>
> Adhering to the mantra of small changes, I would acknowledge this patch
> and get your concerns addressed in another patch. Frans, as one of the
> MythTV maintainers, your Acked-by would be appreciated too, I guess.
>
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

I have no problems with the patch, but it is already pushed, writing
ack messages afterwards seem a little bit useless.

BTW: I never really bothered about mythfront; also I'm not sure if
gmyth still has any significance.

Frans

Re: [PATCH] mythfront-config.bb: Fix do_unpack for machines other than epia.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 684 bytes --]

Am Freitag, den 24.09.2010, 10:30 +0200 schrieb Frans Meulenbroeks:
> 2010/9/24 Paul Menzel <paulepanter@users.sourceforge.net>:
> 
> >
> > Adhering to the mantra of small changes, I would acknowledge this patch
> > and get your concerns addressed in another patch. Frans, as one of the
> > MythTV maintainers, your Acked-by would be appreciated too, I guess.
> >
> > Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
> 
> I have no problems with the patch, but it is already pushed, writing
> ack messages afterwards seem a little bit useless.

You are right. I missed that and was mislead by your comment about the
issue the patch fixed.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]