Re: [PATCH v1 3/4] PPC4xx: New file with SoC specific functions

[Dan Williams <dan.j.williams@intel.com>]

On 9/23/2010 3:11 PM, tmarri@apm.com wrote:
> From: Tirumala Marri<tmarri@apm.com>
>
> This patch creates new file with SoC dependent functions.
>
> Signed-off-by: Tirumala R Marri<tmarri@apm.com>
> ---
> V1:
>    * Remove all 440SPe specific references.

Maybe it renames ppc440spe to ppc4xx but it adds things like...

> +#if defined(CONFIG_440SPe) || defined(CONFIG_440SP)
> +               np = of_find_compatible_node(NULL, NULL, "ibm,i2o-440spe");
> +#endif

...in the code.  Which is 1) not generic and 2) I suspect causes a 
compile warning for using an uninitialized variable.

> +               if (!np) {
> +                       pr_err("%s: can't find I2O device tree node\n",
> +                              __func__);
> +                       ret = -ENODEV;
> +                       goto err_req2;
> +               }

It looks to me like the common code will need to have a few build 
dependent helper routines as it appears one instance of the driver 
cannot simultaneously support 440sp, 440spe, and 460ex.

--
Dan