From: Ben Dooks <ben-linux@fluff.org>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Ben Dooks <ben-linux@fluff.org>,
"Arnaud Patard (Rtp)" <arnaud.patard@rtp-net.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 4/5] h1940: Fix backlight and LCD power functions
Date: Mon, 27 Sep 2010 00:15:36 +0100 [thread overview]
Message-ID: <4C9FD418.8030101@fluff.org> (raw)
In-Reply-To: <1284241518-32587-1-git-send-email-anarsoul@gmail.com>
On 11/09/10 22:45, Vasily Khoruzhick wrote:
Could I have a better explanation of what this part is doing
please.
for future reference, you don't need to put 'this patch' in
the description, that part is pretty clear.
> v2: init gpio mode/value right after gpio_request
It would be helpful to move the changes between submisisons
to under the --- lines to make them easier to remove when
applying to the tree.
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> arch/arm/mach-s3c2410/include/mach/h1940-latch.h | 2 +-
> arch/arm/mach-s3c2410/mach-h1940.c | 80 ++++++++++++++++++----
> 2 files changed, 66 insertions(+), 16 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] h1940: Fix backlight and LCD power functions
Date: Mon, 27 Sep 2010 00:15:36 +0100 [thread overview]
Message-ID: <4C9FD418.8030101@fluff.org> (raw)
In-Reply-To: <1284241518-32587-1-git-send-email-anarsoul@gmail.com>
On 11/09/10 22:45, Vasily Khoruzhick wrote:
Could I have a better explanation of what this part is doing
please.
for future reference, you don't need to put 'this patch' in
the description, that part is pretty clear.
> v2: init gpio mode/value right after gpio_request
It would be helpful to move the changes between submisisons
to under the --- lines to make them easier to remove when
applying to the tree.
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> arch/arm/mach-s3c2410/include/mach/h1940-latch.h | 2 +-
> arch/arm/mach-s3c2410/mach-h1940.c | 80 ++++++++++++++++++----
> 2 files changed, 66 insertions(+), 16 deletions(-)
next prev parent reply other threads:[~2010-09-26 23:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 15:00 [PATCH 0/5] h1940 series Vasily Khoruzhick
2010-09-07 15:00 ` Vasily Khoruzhick
2010-09-07 15:00 ` [PATCH 1/5] h1940: use gpiolib for latch access Vasily Khoruzhick
2010-09-07 15:00 ` Vasily Khoruzhick
2010-09-07 23:13 ` Ben Dooks
2010-09-07 23:13 ` Ben Dooks
2010-09-08 9:39 ` [PATCH v2 " Vasily Khoruzhick
2010-09-08 9:39 ` Vasily Khoruzhick
2010-09-07 15:00 ` [PATCH 2/5] h1940: fix h1940-bluetooth compilation Vasily Khoruzhick
2010-09-07 15:00 ` Vasily Khoruzhick
2010-09-25 23:22 ` Ben Dooks
2010-09-25 23:22 ` Ben Dooks
2010-09-25 23:39 ` Ben Dooks
2010-09-25 23:39 ` Ben Dooks
2010-09-07 15:00 ` [PATCH 3/5] h1940: implement mmc_power function Vasily Khoruzhick
2010-09-07 15:00 ` Vasily Khoruzhick
2010-09-25 23:43 ` Ben Dooks
2010-09-25 23:43 ` Ben Dooks
2010-09-26 21:27 ` [PATCH v2 " Vasily Khoruzhick
2010-09-26 21:27 ` Vasily Khoruzhick
2010-09-07 15:00 ` [PATCH 4/5] h1940: Fix backlight and LCD power functions Vasily Khoruzhick
2010-09-07 15:00 ` Vasily Khoruzhick
2010-09-11 21:45 ` [PATCH v2 " Vasily Khoruzhick
2010-09-11 21:45 ` Vasily Khoruzhick
2010-09-26 23:15 ` Ben Dooks [this message]
2010-09-26 23:15 ` Ben Dooks
2010-09-27 6:28 ` [PATCH v3 " Vasily Khoruzhick
2010-09-27 6:28 ` Vasily Khoruzhick
2010-09-07 23:14 ` [PATCH 0/5] h1940 series Ben Dooks
2010-09-07 23:14 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9FD418.8030101@fluff.org \
--to=ben-linux@fluff.org \
--cc=anarsoul@gmail.com \
--cc=arnaud.patard@rtp-net.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.