[PATCH] SCSI: remove noop in fc_remote_port_add()

[PATCH] SCSI: remove noop in fc_remote_port_add()

[Hillf Danton]

For a deleted scsi target marked as FC_PORTSTATE_BLOCKED,  rescanning
it looks fine.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- o/linux-2.6.36-rc4/drivers/scsi/scsi_transport_fc.c	2010-09-13
07:07:38.000000000 +0800
+++ m/linux-2.6.36-rc4/drivers/scsi/scsi_transport_fc.c	2010-09-24
22:16:26.000000000 +0800
@@ -50,7 +50,6 @@ static int fc_vport_setup(struct Scsi_Ho
 static int fc_bsg_hostadd(struct Scsi_Host *, struct fc_host_attrs *);
 static int fc_bsg_rportadd(struct Scsi_Host *, struct fc_rport *);
 static void fc_bsg_remove(struct request_queue *);
-static void fc_bsg_goose_queue(struct fc_rport *);

 /*
  * Redefine so that we can have same named attributes in the
@@ -2737,8 +2736,6 @@ fc_remote_port_add(struct Scsi_Host *sho
 					spin_unlock_irqrestore(shost->host_lock,
 							flags);

-				fc_bsg_goose_queue(rport);
-
 				return rport;
 			}
 		}
@@ -3753,33 +3750,6 @@ fail_host_msg:
 }


-/*
- * fc_bsg_goose_queue - restart rport queue in case it was stopped
- * @rport:	rport to be restarted
- */
-static void
-fc_bsg_goose_queue(struct fc_rport *rport)
-{
-	int flagset;
-	unsigned long flags;
-
-	if (!rport->rqst_q)
-		return;
-
-	get_device(&rport->dev);
-
-	spin_lock_irqsave(rport->rqst_q->queue_lock, flags);
-	flagset = test_bit(QUEUE_FLAG_REENTER, &rport->rqst_q->queue_flags) &&
-		  !test_bit(QUEUE_FLAG_REENTER, &rport->rqst_q->queue_flags);
-	if (flagset)
-		queue_flag_set(QUEUE_FLAG_REENTER, rport->rqst_q);
-	__blk_run_queue(rport->rqst_q);
-	if (flagset)
-		queue_flag_clear(QUEUE_FLAG_REENTER, rport->rqst_q);
-	spin_unlock_irqrestore(rport->rqst_q->queue_lock, flags);
-
-	put_device(&rport->dev);
-}


 /**

Re: [PATCH] SCSI: remove noop in fc_remote_port_add()

[Hannes Reinecke]

Hillf Danton wrote:
> For a deleted scsi target marked as FC_PORTSTATE_BLOCKED,  rescanning
> it looks fine.
> 
Note that there has been an earlier patch by Christof Schmitt, which
does exactly the same thing plus a slightly more in-depth analysis.
Check for 'scsi: Remove QUEUE_FLAG_REENTER from SCSI code'.

James, comments?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SCSI: remove noop in fc_remote_port_add()

[Hillf Danton]

On Mon, Sep 27, 2010 at 3:09 PM, Hannes Reinecke <hare@suse.de> wrote:
> Hillf Danton wrote:
>> For a deleted scsi target marked as FC_PORTSTATE_BLOCKED,  rescanning
>> it looks fine.
>>
> Note that there has been an earlier patch by Christof Schmitt, which
> does exactly the same thing plus a slightly more in-depth analysis.
> Check for 'scsi: Remove QUEUE_FLAG_REENTER from SCSI code'.
>
What is patched by Christof Schmitt looks better, and
it seems that the queue flag should not be touched outside block core.

> James, comments?
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke                   zSeries & Storage
> hare@suse.de                          +49 911 74053 688
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Markus Rex, HRB 16746 (AG Nürnberg)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html