From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Jim Meyering <jim@meyering.net>,
Project Hail <hail-devel@vger.kernel.org>
Subject: Re: [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam
Date: Mon, 27 Sep 2010 20:23:55 -0400 [thread overview]
Message-ID: <4CA1359B.6030304@garzik.org> (raw)
In-Reply-To: <20100927102927.45686afa@lembas.zaitcev.lan>
On 09/27/2010 12:29 PM, Pete Zaitcev wrote:
> On Mon, 27 Sep 2010 10:53:06 +0200
> Jim Meyering<jim@meyering.net> wrote:
>
>> - stmp = huri_field_escape(strdup(val), QUERY_ESCAPE_MASK);
>> + v = strdup(val);
>> + stmp = huri_field_escape(v, QUERY_ESCAPE_MASK);
>> str = g_string_append(str, stmp);
>> free(stmp);
>> + free(v);
>
> I think you may be fooled by the ridiculous calling convention
Doh, my memory and I were fooled, too.
next prev parent reply other threads:[~2010-09-28 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 8:53 [PATCH hail] lib/hstor.c: avoid an unconditional leak in append_qparam Jim Meyering
2010-09-27 16:29 ` Pete Zaitcev
2010-09-27 17:05 ` Jim Meyering
2010-09-28 0:23 ` Jeff Garzik [this message]
2010-09-27 16:53 ` Jeff Garzik
2010-09-28 0:24 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA1359B.6030304@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=jim@meyering.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.