From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [tabled patch 1/1] Add a test for hstor_keys
Date: Mon, 27 Sep 2010 22:49:46 -0400 [thread overview]
Message-ID: <4CA157CA.1070808@garzik.org> (raw)
In-Reply-To: <20100927185240.31f3265e@lembas.zaitcev.lan>
On 09/27/2010 08:52 PM, Pete Zaitcev wrote:
> Our current tests do not invoke hstor_keys at all, and so they did not catch
> a crash with double free in append_qparam.
>
> Add a very basic test which at least calls hstor_keys to verify that it
> does not crash right away. This test does not excercise complex modes
> such as S3 paging, but better this than nothing.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
> test/Makefile.am | 4 +
> test/list-keys.c | 102 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 105 insertions(+), 1 deletion(-)
applied.. FYI you forgot to update test/.gitignore. Fixed.
prev parent reply other threads:[~2010-09-28 2:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 0:52 [tabled patch 1/1] Add a test for hstor_keys Pete Zaitcev
2010-09-28 2:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA157CA.1070808@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.