From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Arun Murthy <arun.murthy@stericsson.com>
Cc: lars@metafoo.de, akpm@linux-foundation.org,
kernel@pengutronix.de, philipp.zabel@gmail.com,
robert.jarzmik@free.fr, marek.vasut@gmail.com,
eric.y.miao@gmail.com, rpurdie@rpsys.net, sameo@linux.intel.com,
kgene.kim@samsung.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
STEricsson_nomadik_linux@list.st.com
Subject: Re: [PATCH 3/7] leds: pwm: add a new element 'name' to platform data
Date: Tue, 28 Sep 2010 14:43:16 +0400 [thread overview]
Message-ID: <4CA1C6C4.20504@mvista.com> (raw)
In-Reply-To: <1285670134-18063-4-git-send-email-arun.murthy@stericsson.com>
Hello.
On 28-09-2010 14:35, Arun Murthy wrote:
> A new element 'name' is added to pwm led platform data structure.
> This is required to identify the pwm device.
> Signed-off-by: Arun Murthy<arun.murthy@stericsson.com>
> Acked-by: Linus Walleij<linus.walleij@stericsson.com>
[...]
> diff --git a/include/linux/leds_pwm.h b/include/linux/leds_pwm.h
> index 33a0711..7a847a0 100644
> --- a/include/linux/leds_pwm.h
> +++ b/include/linux/leds_pwm.h
> @@ -16,6 +16,7 @@ struct led_pwm {
> struct led_pwm_platform_data {
> int num_leds;
> struct led_pwm *leds;
> + char *name;
> };
Shouldn't '*name'be aligned, at least with '*leds'?
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] leds: pwm: add a new element 'name' to platform data
Date: Tue, 28 Sep 2010 14:43:16 +0400 [thread overview]
Message-ID: <4CA1C6C4.20504@mvista.com> (raw)
In-Reply-To: <1285670134-18063-4-git-send-email-arun.murthy@stericsson.com>
Hello.
On 28-09-2010 14:35, Arun Murthy wrote:
> A new element 'name' is added to pwm led platform data structure.
> This is required to identify the pwm device.
> Signed-off-by: Arun Murthy<arun.murthy@stericsson.com>
> Acked-by: Linus Walleij<linus.walleij@stericsson.com>
[...]
> diff --git a/include/linux/leds_pwm.h b/include/linux/leds_pwm.h
> index 33a0711..7a847a0 100644
> --- a/include/linux/leds_pwm.h
> +++ b/include/linux/leds_pwm.h
> @@ -16,6 +16,7 @@ struct led_pwm {
> struct led_pwm_platform_data {
> int num_leds;
> struct led_pwm *leds;
> + char *name;
> };
Shouldn't '*name'be aligned, at least with '*leds'?
WBR, Sergei
next prev parent reply other threads:[~2010-09-28 10:45 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 10:35 [PATCH 0/7] PWM core driver for pwm based led and backlight driver Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` [PATCH 1/7] pwm: Add pwm core driver Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 12:53 ` Hemanth V
2010-09-28 12:53 ` Hemanth V
2010-09-28 12:53 ` Hemanth V
2010-09-28 13:06 ` Samuel Ortiz
2010-09-28 13:06 ` Samuel Ortiz
2010-09-28 13:35 ` Felipe Balbi
2010-09-28 13:35 ` Felipe Balbi
2010-09-28 13:35 ` Felipe Balbi
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` [PATCH 2/7] backlight:pwm: add an element 'name' to platform data Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` [PATCH 3/7] leds: pwm: add a new " Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:43 ` Sergei Shtylyov [this message]
2010-09-28 10:43 ` Sergei Shtylyov
2010-09-28 10:48 ` Arun MURTHY
2010-09-28 10:48 ` Arun MURTHY
2010-09-28 10:35 ` [PATCH 4/7] pwm: Align existing pwm drivers with pwm-core driver Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` [PATCH 5/7] platform: Update the pwm based led and backlight platform data Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` [PATCH 6/7] pwm: move existing pwm driver to drivers/pwm Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` [PATCH 7/7] pwm: Modify backlight and led Kconfig aligning to pwm core Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
2010-09-28 10:35 ` Arun Murthy
-- strict thread matches above, loose matches on Subject: below --
2010-09-28 7:40 [PATCHv2 0/7] PWM core driver for pwm based led and backlight driver Arun Murthy
2010-09-28 7:40 ` [PATCH 3/7] leds: pwm: add a new element 'name' to platform data Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 7:40 ` Arun Murthy
2010-09-28 8:01 ` Eric Miao
2010-09-28 8:01 ` Eric Miao
2010-09-28 8:36 ` Arun MURTHY
2010-09-28 8:36 ` Arun MURTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA1C6C4.20504@mvista.com \
--to=sshtylyov@mvista.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=akpm@linux-foundation.org \
--cc=arun.murthy@stericsson.com \
--cc=eric.y.miao@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=philipp.zabel@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.