All of lore.kernel.org
 help / color / mirror / Atom feed
From: linus.walleij@stericsson.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10
Date: Tue, 28 Sep 2010 16:53:12 +0200	[thread overview]
Message-ID: <4CA20158.5040700@stericsson.com> (raw)
In-Reply-To: <AANLkTinoGjwWjqHQx-+UB+9K+s97t9c0y5i5-rdw=UA4@mail.gmail.com>

Dan Williams wrote:
> [Me]
>> As mentioned I have no clue to why this failed to compile for Grant,
>> please see if this tenth version is still problematic or if it was
>> something intermittent.
>>
>> Else I really need help in knowing what config to compile, this was
>> compiled for U300, U8500 and RealView with and without DMA enabled.
> 
> Maybe it makes more sense for these filter_id functions to be defined
> in the arch code rather than the dma driver.  Right now there seems to
> be a weird dependency of arch requires dma-driver, dma-driver requires
> arch, and slave-driver requires arch and dma-driver in order to
> dynamically select dma-driver with dma_request_channel().  It forces
> dma-driver and slave-driver to always be compiled in, if I am reading
> this correctly.

I think what happened was two things:

- First that I was switching on CONFIG_DMADEVICES rather than
  CONFIG_DMA_ENGINE which caused the immediate compile warnings

- Second I had no dummy filter function for COH901318 and ste_dma40
  in case the driver was not compiled in or available as
  module.

I actually think it is OK to request that DMA drivers always be
compiled in for slave transfer support, they are *really* infrastructure
IMO.

And that is why "my" drivers are Kconfig:ed bool.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@stericsson.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"yuanyabin1978@sina.com" <yuanyabin1978@sina.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10
Date: Tue, 28 Sep 2010 16:53:12 +0200	[thread overview]
Message-ID: <4CA20158.5040700@stericsson.com> (raw)
In-Reply-To: <AANLkTinoGjwWjqHQx-+UB+9K+s97t9c0y5i5-rdw=UA4@mail.gmail.com>

Dan Williams wrote:
> [Me]
>> As mentioned I have no clue to why this failed to compile for Grant,
>> please see if this tenth version is still problematic or if it was
>> something intermittent.
>>
>> Else I really need help in knowing what config to compile, this was
>> compiled for U300, U8500 and RealView with and without DMA enabled.
> 
> Maybe it makes more sense for these filter_id functions to be defined
> in the arch code rather than the dma driver.  Right now there seems to
> be a weird dependency of arch requires dma-driver, dma-driver requires
> arch, and slave-driver requires arch and dma-driver in order to
> dynamically select dma-driver with dma_request_channel().  It forces
> dma-driver and slave-driver to always be compiled in, if I am reading
> this correctly.

I think what happened was two things:

- First that I was switching on CONFIG_DMADEVICES rather than
  CONFIG_DMA_ENGINE which caused the immediate compile warnings

- Second I had no dummy filter function for COH901318 and ste_dma40
  in case the driver was not compiled in or available as
  module.

I actually think it is OK to request that DMA drivers always be
compiled in for slave transfer support, they are *really* infrastructure
IMO.

And that is why "my" drivers are Kconfig:ed bool.

Yours,
Linus Walleij

  reply	other threads:[~2010-09-28 14:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01 15:24 PrimeCell generic DMA v10 Linus Walleij
2010-09-01 15:24 ` Linus Walleij
2010-09-01 15:24 ` [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10 Linus Walleij
2010-09-01 15:24   ` Linus Walleij
2010-09-01 15:24   ` [PATCH 2/6] ARM: add PrimeCell generic DMA to PL011 v10 Linus Walleij
2010-09-01 15:24     ` Linus Walleij
2010-09-01 15:24     ` [PATCH 3/6] ARM: add PrimeCell generic DMA to MMCI/PL180 v10 Linus Walleij
2010-09-01 15:24       ` Linus Walleij
2010-09-01 15:24       ` [PATCH 4/6] ARM: config U300 PL180 PL011 PL022 for DMA v10 Linus Walleij
2010-09-01 15:24         ` Linus Walleij
2010-09-01 15:24         ` [PATCH 5/6] ARM: config Ux500 PL011 PL022 PL180 " Linus Walleij
2010-09-01 15:24           ` Linus Walleij
2010-09-01 15:24           ` [PATCH 6/6] ARM: config RealViews PL011 PL022 " Linus Walleij
2010-09-01 15:24             ` Linus Walleij
2010-09-01 15:24             ` Linus Walleij
2010-09-01 15:24               ` Linus Walleij
2010-09-23 21:31   ` [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10 Dan Williams
2010-09-23 21:31     ` Dan Williams
2010-09-28 14:53     ` Linus Walleij [this message]
2010-09-28 14:53       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA20158.5040700@stericsson.com \
    --to=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.