From: Denis Kirjanov <dkirjanov@kernel.org>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] staging: slicoss: use free_netdev(netdev) instead
Date: Tue, 28 Sep 2010 19:23:01 +0000 [thread overview]
Message-ID: <4CA24095.6090706@kernel.org> (raw)
In-Reply-To: <1285693688-4763-1-git-send-email-segooon@gmail.com>
On 09/28/2010 09:08 PM, Vasiliy Kulikov wrote:
> Freeing netdev without free_netdev() leads to net, tx leaks.
> I might lead to dereferencing freed pointer.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> @@
> struct net_device* dev;
> @@
>
> -kfree(dev)
> +free_netdev(dev)
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> Compile tested.
>
> drivers/staging/slicoss/slicoss.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 58ff123..18f1103 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -3233,7 +3233,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
> slic_global.num_slic_cards--;
> slic_card_cleanup(card);
> }
> - kfree(dev);
> + free_netdev(dev);
> pci_release_regions(pcidev);
> }
>
Acked-by: Denis Kirjanov <dkirjanov@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Denis Kirjanov <dkirjanov@kernel.org>
To: Vasiliy Kulikov <segooon@gmail.com>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jpirko@redhat.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/9] staging: slicoss: use free_netdev(netdev) instead of kfree()
Date: Tue, 28 Sep 2010 23:23:01 +0400 [thread overview]
Message-ID: <4CA24095.6090706@kernel.org> (raw)
In-Reply-To: <1285693688-4763-1-git-send-email-segooon@gmail.com>
On 09/28/2010 09:08 PM, Vasiliy Kulikov wrote:
> Freeing netdev without free_netdev() leads to net, tx leaks.
> I might lead to dereferencing freed pointer.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> @@
> struct net_device* dev;
> @@
>
> -kfree(dev)
> +free_netdev(dev)
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
> Compile tested.
>
> drivers/staging/slicoss/slicoss.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index 58ff123..18f1103 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -3233,7 +3233,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
> slic_global.num_slic_cards--;
> slic_card_cleanup(card);
> }
> - kfree(dev);
> + free_netdev(dev);
> pci_release_regions(pcidev);
> }
>
Acked-by: Denis Kirjanov <dkirjanov@kernel.org>
next prev parent reply other threads:[~2010-09-28 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 9:58 [PATCH 8/9] staging: slicoss: use free_netdev(netdev) instead of kfree() Vasiliy Kulikov
2010-09-26 9:58 ` Vasiliy Kulikov
2010-09-26 14:35 ` [PATCH 8/9] staging: slicoss: use free_netdev(netdev) instead Denis Kirjanov
2010-09-26 14:35 ` [PATCH 8/9] staging: slicoss: use free_netdev(netdev) instead of kfree() Denis Kirjanov
2010-09-28 17:08 ` Vasiliy Kulikov
2010-09-28 17:08 ` Vasiliy Kulikov
2010-09-28 19:23 ` Denis Kirjanov [this message]
2010-09-28 19:23 ` Denis Kirjanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA24095.6090706@kernel.org \
--to=dkirjanov@kernel.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jpirko@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.