Re: [v4] wvstreams-4.6: Remove dbus support (breaks build)

[Thilo Fromm <t.fromm@dresearch.de>]

Hello Paul,

>> If wvstreams is configured with DBus support enabled (by not providing
>> --without-dbus) the the build fails at link time as libdbus cannot be
>> found.
>>
>> This patch, however, does not fix the configure.ac file but disables
>> DBus support for wvstreams at configure time. This at least fixes the
>> broken build.
>>
>> Signed-off-by: Thilo Fromm<t.fromm@dresearch.de>
>
> I build tested your patch with `MACHINE = "beagleboard"` and
> distributions Ȧngström 2008.1 and Minimal with `LIBC = "libc"`.
>
> But it fails for me for Minimal with `LIBC = "eglibc"`
[...]
> 	| utils/wvtask.cc:477:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:521:63: error: 'makecontext' was not declared in this scope
> 	| utils/wvtask.cc:526:52: error: 'setcontext' was not declared in this scope
> 	| make: *** [utils/wvtask.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 11 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed

I see. I've never seen these failures, but then, I always run glibc builds.

> and minimal-uclibc.
[...]
> 	| ./CXX -c ipstreams/wvunixdgsocket
> 	| In file included from ./include/wvunixdgsocket.h:13:0,
> 	|                  from ipstreams/wvunixdgsocket.cc:1:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
> 	| ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
> 	| make: *** [ipstreams/wvunixdgsocket.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 12 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
>
> […]
>
> I am not sure, but your patch is an improvement for GNU Libc based
> distributions and so your patch could as well be commit.

Weird, though. My patch didn't introduce anything obvious that would 
make non-glibc builds fail. Did you try building wvstreams-4.6 / eglibc 
or wvstreams-4.6 / uClibc without my patch applied?

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle