Re: [v4] wvstreams-4.6: Remove dbus support (breaks build)

[Steffen Sledz <sledz@dresearch.de>]

Am 29.09.2010 10:20, schrieb Paul Menzel:
> Am Dienstag, den 28.09.2010, 11:34 +0200 schrieb Thilo Fromm: 
>> If wvstreams is configured with DBus support enabled (by not providing
>> --without-dbus) the the build fails at link time as libdbus cannot be
>> found:
>>
>> | ./CXX -c dbus/wvdbusconn
>> | ./CXX -c dbus/wvdbusmarshal
>> | ./CXX -c dbus/wvdbusmsg
>> | ./CXX -c dbus/wvdbusserver
>> | linking libwvdbus.so...
>> | arm-angstrom-linux-gnueabi-g++: /libdbus-1.a: No such file or directory
>> | make: *** [libwvdbus.so] Error 1
>> | FATAL: oe_runmake failed
>> NOTE: Task failed: /SCRATCH/maniac/oe-merge-test/OE/tmp.6/work/armv5te-angstrom-linux-gnueabi/wvstreams-4.6-r0/temp/log.do_compile.6422
>> ERROR: TaskFailed event exception, aborting
>> ERROR: Build of /home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
>> ERROR: Task 2024 (/home/maniac/work/HYP/oe/3way_merge/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed
>>
>> The root cause for this behaviour is in wvstreams' configure.ac; the
>> weird dbus detection and library path handling breaks successive builds.
>>
>> This patch, however, does not fix the configure.ac file but disables
>> DBus support for wvstreams at configure time. This at least fixes the
>> broken build.
>>
>> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
> 
> I build tested your patch with `MACHINE = "beagleboard"` and
> distributions Ȧngström 2008.1 and Minimal with `LIBC = "libc"`.
> 
> But it fails for me for Minimal with `LIBC = "eglibc"`
> 
> 	| make[1]: Leaving directory `/oe/build-minimal-uclibc/minimal-uclibc-dev/work/armv7a-oe-linux-uclibceabi/wvstreams-4.6-r1/wvstreams-4.6/argp'
> 	| ./CXX -c utils/wvbuffer
> 	| ./CXX -c utils/wvbufferstore
> 	| ./CXX -c utils/wvcont
> 	| ./CXX -c utils/wverror
> 	| ./CXX -c streams/wvfdstream
> 	| ./CXX -c utils/wvfork
> 	| ./CXX -c utils/wvhash
> 	| ./CXX -c utils/wvhashtable
> 	| ./CXX -c utils/wvlinklist
> 	| ./CXX -c utils/wvmoniker
> 	| ./CXX -c utils/wvregex
> 	| ./CXX -c utils/wvscatterhash
> 	| ./CXX -c utils/wvsorter
> 	| ./CXX -c utils/wvattrs
> 	| ./CXX -c utils/wvstring
> 	| ./CXX -c utils/wvstringlist
> 	| ./CXX -c utils/wvstringmask
> 	| ./CXX -c utils/strutils
> 	| ./CXX -c utils/wvtask
> 	| utils/wvtask.cc: In constructor 'WvTaskMan::WvTaskMan()':
> 	| utils/wvtask.cc:202:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static int WvTaskMan::run(WvTask&, int)':
> 	| utils/wvtask.cc:268:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:274:33: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static int WvTaskMan::yield(int)':
> 	| utils/wvtask.cc:322:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:328:29: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static void WvTaskMan::get_stack(WvTask&, size_t)':
> 	| utils/wvtask.cc:344:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:374:30: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static void WvTaskMan::_stackmaster()':
> 	| utils/wvtask.cc:412:9: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:422:41: error: 'setcontext' was not declared in this scope
> 	| utils/wvtask.cc: In static member function 'static void WvTaskMan::do_task()':
> 	| utils/wvtask.cc:477:5: error: 'getcontext' was not declared in this scope
> 	| utils/wvtask.cc:521:63: error: 'makecontext' was not declared in this scope
> 	| utils/wvtask.cc:526:52: error: 'setcontext' was not declared in this scope
> 	| make: *** [utils/wvtask.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 11 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 
> and minimal-uclibc.
> 
> 	| ./CXX -c ipstreams/wvaddr
> 	| In file included from ipstreams/wvaddr.cc:19:0:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvipraw
> 	| In file included from ./include/wvipraw.h:10:0,
> 	|                  from ipstreams/wvipraw.cc:8:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvlistener
> 	| In file included from ipstreams/wvlistener.cc:10:0:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvresolver
> 	| In file included from ./include/wvresolver.h:10:0,
> 	|                  from ipstreams/wvresolver.cc:7:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvstreamsdebuggerserver
> 	| In file included from ./include/wvstreamsdebuggerserver.h:12:0,
> 	|                  from ipstreams/wvstreamsdebuggerserver.cc:6:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvtcp
> 	| In file included from ./include/wvtcplistener.h:11:0,
> 	|                  from ipstreams/wvtcp.cc:7:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvudp
> 	| In file included from ./include/wvudp.h:10:0,
> 	|                  from ipstreams/wvudp.cc:8:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ./CXX -c ipstreams/wvunixdgsocket
> 	| In file included from ./include/wvunixdgsocket.h:13:0,
> 	|                  from ipstreams/wvunixdgsocket.cc:1:
> 	| ./include/wvaddr.h: In member function 'uint32_t WvIPAddr::addr() const':
> 	| ./include/wvaddr.h:284:31: warning: dereferencing type-punned pointer will break strict-aliasing rules
> 	| ipstreams/wvunixdgsocket.cc: In constructor 'WvUnixDGSocket::WvUnixDGSocket(const WvFastString&, bool, int)':
> 	| ipstreams/wvunixdgsocket.cc:50:32: error: 'chmod' was not declared in this scope
> 	| make: *** [ipstreams/wvunixdgsocket.o] Error 1
> 	| FATAL: oe_runmake failed
> 	| ERROR: Function do_compile failed
> 	NOTE: package wvstreams-4.6-r1: task do_compile: Failed
> 	ERROR: TaskFailed event exception, aborting
> 	ERROR: Build of /oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb do_compile failed
> 	ERROR: Task 12 (/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb, do_compile) failed with 256
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 	ERROR: '/oe/openembedded/recipes/wvstreams/wvstreams_4.6.bb' failed
> 
> […]
> 
> I am not sure, but your patch is an improvement for GNU Libc based
> distributions and so your patch could as well be commit.
> 
> Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>

Acked-by: Steffen Sledz <sledz@dresearch.de>

and applied

-- 
Steffen Sledz
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str.3, D-10319 Berlin, Germany
Tel: +49 (30) 515932237 mailto:sledz@DResearch.DE
Fax: +49 (30) 515932299 http://www.DResearch.DE
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 54412;
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642