[PATCH] qemu-0.12.5: add ncurses, gnutls dependencies

[PATCH] qemu-0.12.5: add ncurses, gnutls dependencies

[Thilo Fromm]

QEmu build breaks occassionally because some of the libraries required
have not been built at the time qemu is being built. I ran into problems
with the "qemu-native" build which tried to link against host libraries
and subsequently failed:

....

|   LINK  sh4eb-softmmu/qemu-system-sh4eb
|   LINK  sh4-softmmu/qemu-system-sh4
|   LINK  mips-softmmu/qemu-system-mips
|   CC    mips64el-softmmu/fpu/softfloat.o
|   CC    sparc-softmmu/i386-dis.o
| /usr/lib/gcc/x86_64-linux-gnu/4.4.3/../../../../lib/libgnutls.so: undefined reference to `gcry_cipher_setkey@GCRYPT_1.2'
| /usr/lib/gcc/x86_64-linux-gnu/4.4.3/../../../../lib/libgnutls.so: undefined reference to `gcry_cipher_setiv@GCRYPT_1.2'
| collect2: ld returned 1 exit status
| make[1]: *** [qemu-system-mips] Error 1
| make: *** [subdir-mips-softmmu] Error 2

....

This patch adds gnutls and ncurses dependencies to the recipe.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 recipes/qemu/qemu_0.12.5.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes/qemu/qemu_0.12.5.bb b/recipes/qemu/qemu_0.12.5.bb
index c823fbd..a8d67f1 100644
--- a/recipes/qemu/qemu_0.12.5.bb
+++ b/recipes/qemu/qemu_0.12.5.bb
@@ -1,7 +1,7 @@
 LICENSE = "GPL"
-DEPENDS = "zlib"
+DEPENDS = "zlib ncurses gnutls"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "\
     http://download.savannah.gnu.org/releases/qemu/qemu-${PV}.tar.gz \
-- 
1.7.0.4

Re: [PATCH] qemu-0.12.5: add ncurses, gnutls dependencies

[Holger Freyther]

On 09/29/2010 10:48 PM, Thilo Fromm wrote:
> QEmu build breaks occassionally because some of the libraries required
> have not been built at the time qemu is being built. I ran into problems
> with the "qemu-native" build which tried to link against host libraries
> and subsequently failed:

> | /usr/lib/gcc/x86_64-linux-gnu/4.4.3/../../../../lib/libgnutls.so: undefined reference to `gcry_cipher_setkey@GCRYPT_1.2'
> | /usr/lib/gcc/x86_64-linux-gnu/4.4.3/../../../../lib/libgnutls.so: undefined reference to `gcry_cipher_setiv@GCRYPT_1.2'

hmm no... the bug is more with libgnutls of your system not linking to gcrypt.
I have this with JHBUILD building GNOME 3.x.

Re: [PATCH] qemu-0.12.5: add ncurses, gnutls dependencies

[Thilo Fromm]

Hello, Holger,

>> QEmu build breaks occassionally because some of the libraries required
>> have not been built at the time qemu is being built. I ran into problems
>> with the "qemu-native" build which tried to link against host libraries
>> and subsequently failed:
>
>> | /usr/lib/gcc/x86_64-linux-gnu/4.4.3/../../../../lib/libgnutls.so: undefined reference to `gcry_cipher_setkey@GCRYPT_1.2'
>> | /usr/lib/gcc/x86_64-linux-gnu/4.4.3/../../../../lib/libgnutls.so: undefined reference to `gcry_cipher_setiv@GCRYPT_1.2'
>
> hmm no... the bug is more with libgnutls of your system not linking to gcrypt.
> I have this with JHBUILD building GNOME 3.x.

That's the point: qemu is not supposed to link against my host 
libraries. It should use OpenEmbedded staging libraries for this. Also, 
the recipe explicitly points the qemu build to the native staging 
"includes" directory already. After adding gnutls and ncurses to the 
dependencies qemu linked the native staging libs as expected, and the 
build is now successful.

Anyway, qemu _does_ link against gnutls and ncurses at some point in its 
build process. So why not provide these dependencies? I guess it could 
be important for a target build, too.

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [PATCH] qemu-0.12.5: add ncurses, gnutls dependencies

[Holger Freyther]

On 09/29/2010 11:07 PM, Thilo Fromm wrote:
> Hello, Holger,

> Anyway, qemu _does_ link against gnutls and ncurses at some point in its build
> process. So why not provide these dependencies? I guess it could be important
> for a target build, too.

true, we tend to add circular deps though (e.g. when I tried to enable SDL
mode), so it would be nice if you could test with a clean rebuild.

Re: [PATCH] qemu-0.12.5: add ncurses, gnutls dependencies

[Thilo Fromm]

Hello Holger,

>> Anyway, qemu _does_ link against gnutls and ncurses at some point in its build
>> process. So why not provide these dependencies? I guess it could be important
>> for a target build, too.
>
> true, we tend to add circular deps though (e.g. when I tried to enable SDL
> mode), so it would be nice if you could test with a clean rebuild.

I did. I wouldn't submit a patch without testing it in advance. We run 
our own platform - hipox - and we use Angstrom 2008.1 on that. 
Everything built nicely from scratch.

I'd be happy for some pointers / info if there's a special platform / 
target / distribution I should build for a clean "from scratch" test build.

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle