falloc.h missing: util-linux-ng-2.17 build fails against 2.6.24

falloc.h missing: util-linux-ng-2.17 build fails against 2.6.24

[Thilo Fromm]

Hello *.*,

When building the latest trunk against kernel 2.6.24 the build fails for 
at least util-linux-ng-2.17 because the kernel header file "falloc.h" is 
not present:

|
| fallocate.c:40:54: error: linux/falloc.h: No such file or directory
| fallocate.c: In function 'main':
| fallocate.c:132: error: 'FALLOC_FL_KEEP_SIZE' undeclared (first use in 
this function)
| fallocate.c:132: error: (Each undeclared identifier is reported only once
| fallocate.c:132: error: for each function it appears in.)
| make[2]: *** [fallocate.o] Error 1
| make[2]: *** Waiting for unfinished jobs....


This happens because linux-libc-headers for 2.6.24 does not provide 
falloc.h - although it's present in the kernel it is not exported during 
make headers_install.

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

[PATCH] Add falloc.h to the exported kernel header files.

[Thilo Fromm]

This adds include/linux/falloc.h to the list of files
exported by the kernel to the C library.
The include file is required for building e.g. a recent util-linux-ng
against 2.6.24.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    1 +
 2 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch

diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
new file mode 100644
index 0000000..5860e88
--- /dev/null
+++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
@@ -0,0 +1,10 @@
+--- a/include/linux/Kbuild	2010-09-27 16:04:29.000000000 +0200
++++ b/include/linux/Kbuild	2010-09-27 15:59:06.000000000 +0200
+@@ -61,6 +61,7 @@
+ header-y += elf.h
+ header-y += elf-em.h
+ header-y += fadvise.h
++header-y += falloc.h
+ header-y += fd.h
+ header-y += fdreg.h
+ header-y += fib_rules.h
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index b90c478..6db6fd1 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -6,6 +6,7 @@ PR = "r5"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
+           file://export_falloc_h.patch \
            file://unifdef.patch"
 
 S = "${WORKDIR}/linux-${PV}"
-- 
1.7.0.4

Re: [PATCH] Add falloc.h to the exported kernel header files.

[Steffen Sledz]

Am 27.09.2010 17:23, schrieb Thilo Fromm:
> This adds include/linux/falloc.h to the list of files
> exported by the kernel to the C library.
> The include file is required for building e.g. a recent util-linux-ng
> against 2.6.24.
> 
> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>

Acked-by: Steffen Sledz <sledz@dresearch.de>

Re: [PATCH] Add falloc.h to the exported kernel header files.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2748 bytes --]

Dear Thilo,


thank you for your patch. Could you please add the recipe name to the
beginning of the commit summary as demanded by the commit policy
[1]. ;-)


Am Montag, den 27.09.2010, 17:23 +0200 schrieb Thilo Fromm:
> This adds include/linux/falloc.h to the list of files
> exported by the kernel to the C library.
> The include file is required for building e.g. a recent util-linux-ng
> against 2.6.24.

it looks like the same fix was committed upstream [3] in March 2008 [4].
Since the Linux kernel 2.6.24 was released in January 2008 this fixed
should be present in all Linux kernels >= 2.6.24.

If you sent a patch iteration, please add that information to the commit
message.

> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
> ---
>  .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    1 +
>  2 files changed, 11 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch
> 
> diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
> new file mode 100644
> index 0000000..5860e88
> --- /dev/null
> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch

Could you please add a patch header as suggested in [2].

> @@ -0,0 +1,10 @@
> +--- a/include/linux/Kbuild	2010-09-27 16:04:29.000000000 +0200
> ++++ b/include/linux/Kbuild	2010-09-27 15:59:06.000000000 +0200
> +@@ -61,6 +61,7 @@
> + header-y += elf.h
> + header-y += elf-em.h
> + header-y += fadvise.h
> ++header-y += falloc.h
> + header-y += fd.h
> + header-y += fdreg.h
> + header-y += fib_rules.h
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> index b90c478..6db6fd1 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> @@ -6,6 +6,7 @@ PR = "r5"
>  
>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
>             file://procinfo.h \
> +           file://export_falloc_h.patch \
>             file://unifdef.patch"
>  
>  S = "${WORKDIR}/linux-${PV}"


Thanks,

Paul


[1] http://wiki.openembedded.net/index.php/Commit_Policy
[2] http://wiki.openembedded.net/index.php/Push_patches_upstream
[3] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=include/linux/Kbuild;h=626b629429ff2fc3f30fcf63b25fb52211f184c0;hb=HEAD#l120
[4] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e
[5] http://kernelnewbies.org/Linux_2_6_24

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] Add falloc.h to the exported kernel header files.

[Thilo Fromm]

Hello Paul,

> thank you for your patch. Could you please add the recipe name to the
> beginning of the commit summary as demanded by the commit policy
> [1]. ;-)

I will. This one actually was my first patch (I made the same mistake in 
my second patch - the wvstreams dbus issue - which I already fixed), so 
don't worry, my commit summary naming should be OK for future patches :)

>> This adds include/linux/falloc.h to the list of files
>> exported by the kernel to the C library.
>> The include file is required for building e.g. a recent util-linux-ng
>> against 2.6.24.
>
> it looks like the same fix was committed upstream [3] in March 2008 [4].
> Since the Linux kernel 2.6.24 was released in January 2008 this fixed
> should be present in all Linux kernels>= 2.6.24.

It is present in all kernels > 2.6.24. It's actually in the changelog 
for 2.6.25: 
<http://ftp.halifax.rwth-aachen.de/kernel/linux/kernel/v2.6/ChangeLog-2.6.25> 
(search the page for "falloc.h").

But we're stuck with 2.6.24 :-/

> If you sent a patch iteration, please add that information to the commit
> message.

What's a patch iteration?

>> Signed-off-by: Thilo Fromm<t.fromm@dresearch.de>
>> ---
>>   .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
>>   .../linux-libc-headers_2.6.24.bb                   |    1 +
>>   2 files changed, 11 insertions(+), 0 deletions(-)
>>   create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch
>>
>> diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
>> new file mode 100644
>> index 0000000..5860e88
>> --- /dev/null
>> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
>
> Could you please add a patch header as suggested in [2].

I suppose you're referring to a line like

upstream: OE-only

? As this patch is not supposed to go upstream (because it's already 
there) - do you think this is still necessary?

Otherwise I'd just adjust the patch summary and then resubmit the patch 
as v2.

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [PATCH] Add falloc.h to the exported kernel header files.

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2499 bytes --]

Dear Thilo,


Am Mittwoch, den 29.09.2010, 17:31 +0200 schrieb Thilo Fromm:

[…]

> >> This adds include/linux/falloc.h to the list of files
> >> exported by the kernel to the C library.
> >> The include file is required for building e.g. a recent util-linux-ng
> >> against 2.6.24.
> >
> > it looks like the same fix was committed upstream [3] in March 2008 [4].
> > Since the Linux kernel 2.6.24 was released in January 2008 this fixed
> > should be present in all Linux kernels>= 2.6.24.
> 
> It is present in all kernels > 2.6.24. It's actually in the changelog 
> for 2.6.25: 
> <http://ftp.halifax.rwth-aachen.de/kernel/linux/kernel/v2.6/ChangeLog-2.6.25> 
> (search the page for "falloc.h").
> 
> But we're stuck with 2.6.24 :-/
> 
> > If you sent a patch iteration, please add that information to the commit
> > message.
> 
> What's a patch iteration?

I am no native speaker, but I mean a revised patch, i. e. PATCH v2.

> >> Signed-off-by: Thilo Fromm<t.fromm@dresearch.de>
> >> ---
> >>   .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
> >>   .../linux-libc-headers_2.6.24.bb                   |    1 +
> >>   2 files changed, 11 insertions(+), 0 deletions(-)
> >>   create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch
> >>
> >> diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
> >> new file mode 100644
> >> index 0000000..5860e88
> >> --- /dev/null
> >> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
> >
> > Could you please add a patch header as suggested in [2].
> 
> I suppose you're referring to a line like
> 
> upstream: OE-only
> 
> ? As this patch is not supposed to go upstream (because it's already 
> there) - do you think this is still necessary?

I looked at your revised patch (v2). This information is not for the
commit message but should be placed at the beginning of the patch file
`files/export_falloc_h.patch` [1]. My suggestion is the following.

        upstream: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e
        comment: Patch is present in Linux kernel >= 2.6.25.

> Otherwise I'd just adjust the patch summary and then resubmit the patch 
> as v2.


Thanks,

Paul


[1] http://cgit.openembedded.org/cgit.cgi/openembedded/tree/recipes/eglibc/files/eglibc-dont-cache-slibdir.patch

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

[PATCH v2] linux-libc-headers (2.6.24): Add falloc.h to kernel exported headers

[Thilo Fromm]

upstream: OE-only
This adds include/linux/falloc.h to the list of files exported by the kernel 
to the C library. The include file is required for building e.g. a recent 
util-linux-ng against 2.6.24.

Starting from 2.6.25 a similar patch has been accepted upstream (the mainline 
kernel). For 2.6.24, however, falloc.h is not exported although it's present.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    1 +
 2 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch

diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
new file mode 100644
index 0000000..5860e88
--- /dev/null
+++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
@@ -0,0 +1,10 @@
+--- a/include/linux/Kbuild	2010-09-27 16:04:29.000000000 +0200
++++ b/include/linux/Kbuild	2010-09-27 15:59:06.000000000 +0200
+@@ -61,6 +61,7 @@
+ header-y += elf.h
+ header-y += elf-em.h
+ header-y += fadvise.h
++header-y += falloc.h
+ header-y += fd.h
+ header-y += fdreg.h
+ header-y += fib_rules.h
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index b90c478..6db6fd1 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -6,6 +6,7 @@ PR = "r5"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
+           file://export_falloc_h.patch \
            file://unifdef.patch"
 
 S = "${WORKDIR}/linux-${PV}"
-- 
1.7.0.4

Re: [PATCH v2] linux-libc-headers (2.6.24): Add falloc.h to kernel exported headers

[Steffen Sledz]

Am 29.09.2010 17:43, schrieb Thilo Fromm:
> upstream: OE-only
> This adds include/linux/falloc.h to the list of files exported by the kernel 
> to the C library. The include file is required for building e.g. a recent 
> util-linux-ng against 2.6.24.
> 
> Starting from 2.6.25 a similar patch has been accepted upstream (the mainline 
> kernel). For 2.6.24, however, falloc.h is not exported although it's present.
> 
> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>

Acked-by: Steffen Sledz <sledz@dresearch.de>

-- 
Steffen Sledz
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str.3, D-10319 Berlin, Germany
Tel: +49 (30) 515932237 mailto:sledz@DResearch.DE
Fax: +49 (30) 515932299 http://www.DResearch.DE
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 54412;
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642

Re: [PATCH v2] linux-libc-headers (2.6.24): Add falloc.h to kernel exported headers

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2307 bytes --]

Dear Thilo,


although not very important I think it is better to write

	linux-libc-headers_2.6.24

in the commit summary.


Am Mittwoch, den 29.09.2010, 17:43 +0200 schrieb Thilo Fromm:
> upstream: OE-only

This can be omitted in the commit message.

> This adds include/linux/falloc.h to the list of files exported by the kernel 
> to the C library. The include file is required for building e.g. a recent 
> util-linux-ng against 2.6.24.
> 
> Starting from 2.6.25 a similar patch has been accepted upstream (the mainline 
> kernel). For 2.6.24, however, falloc.h is not exported although it's present.
> 
> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
> ---
>  .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    1 +
>  2 files changed, 11 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch
> 
> diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
> new file mode 100644
> index 0000000..5860e88
> --- /dev/null
> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch

Just for the record. Please add the patch header as I wrote in my other
message

> @@ -0,0 +1,10 @@
> +--- a/include/linux/Kbuild	2010-09-27 16:04:29.000000000 +0200
> ++++ b/include/linux/Kbuild	2010-09-27 15:59:06.000000000 +0200
> +@@ -61,6 +61,7 @@
> + header-y += elf.h
> + header-y += elf-em.h
> + header-y += fadvise.h
> ++header-y += falloc.h
> + header-y += fd.h
> + header-y += fdreg.h
> + header-y += fib_rules.h
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> index b90c478..6db6fd1 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> @@ -6,6 +6,7 @@ PR = "r5"
>  
>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
>             file://procinfo.h \
> +           file://export_falloc_h.patch \
>             file://unifdef.patch"
>  
>  S = "${WORKDIR}/linux-${PV}"

I think the next iteration will be ready to be committed.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v2] linux-libc-headers (2.6.24): Add falloc.h to kernel exported headers

[Thilo Fromm]

Hello Paul,

> although not very important I think it is better to write
>
> 	linux-libc-headers_2.6.24
>
> in the commit summary.

OK.

>> upstream: OE-only
>
> This can be omitted in the commit message.

Yupp, I think I now understand the purpose of this tag, any that I put 
it at the wrong place.

>> This adds include/linux/falloc.h to the list of files exported by the kernel
>> to the C library. The include file is required for building e.g. a recent
>> util-linux-ng against 2.6.24.
>>
>> Starting from 2.6.25 a similar patch has been accepted upstream (the mainline
>> kernel). For 2.6.24, however, falloc.h is not exported although it's present.
>>
>> Signed-off-by: Thilo Fromm<t.fromm@dresearch.de>
>> ---
>>   .../linux-libc-headers/files/export_falloc_h.patch |   10 ++++++++++
>>   .../linux-libc-headers_2.6.24.bb                   |    1 +
>>   2 files changed, 11 insertions(+), 0 deletions(-)
>>   create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch
>>
>> diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
>> new file mode 100644
>> index 0000000..5860e88
>> --- /dev/null
>> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
>
> Just for the record. Please add the patch header as I wrote in my other
> message

I missed the spot. Sorry for that. I'll fix this.

> I think the next iteration will be ready to be committed.

Cool :)

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

[PATCH v3] linux-libc-headers_2.6.24: Add falloc.h to kernel exported headers

[Thilo Fromm]

This adds include/linux/falloc.h to the list of files exported by the kernel to the C library.
The include file is required for building e.g. a recent util-linux-ng against 2.6.24.

Starting from 2.6.25 a similar patch has been accepted upstream (the mainline
kernel). For 2.6.24, however, falloc.h is not exported although it's present.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 .../linux-libc-headers/files/export_falloc_h.patch |   11 +++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    3 ++-
 2 files changed, 13 insertions(+), 1 deletions(-)
 create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch

diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
new file mode 100644
index 0000000..2133a36
--- /dev/null
+++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
@@ -0,0 +1,11 @@
+upstream: OE-only
+--- a/include/linux/Kbuild	2010-09-27 16:04:29.000000000 +0200
++++ b/include/linux/Kbuild	2010-09-27 15:59:06.000000000 +0200
+@@ -61,6 +61,7 @@
+ header-y += elf.h
+ header-y += elf-em.h
+ header-y += fadvise.h
++header-y += falloc.h
+ header-y += fd.h
+ header-y += fdreg.h
+ header-y += fib_rules.h
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index b90c478..e95299b 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -2,10 +2,11 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r5"
+PR = "r6"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
+           file://export_falloc_h.patch \
            file://unifdef.patch"
 
 S = "${WORKDIR}/linux-${PV}"
-- 
1.7.0.4

Re: [PATCH v3] linux-libc-headers_2.6.24: Add falloc.h to kernel exported headers

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2434 bytes --]

Am Donnerstag, den 30.09.2010, 14:40 +0200 schrieb Thilo Fromm:
> This adds include/linux/falloc.h to the list of files exported by the kernel to the C library.
> The include file is required for building e.g. a recent util-linux-ng against 2.6.24.
> 
> Starting from 2.6.25 a similar patch has been accepted upstream (the mainline
> kernel). For 2.6.24, however, falloc.h is not exported although it's present.
> 
> Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
> ---
>  .../linux-libc-headers/files/export_falloc_h.patch |   11 +++++++++++
>  .../linux-libc-headers_2.6.24.bb                   |    3 ++-
>  2 files changed, 13 insertions(+), 1 deletions(-)
>  create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch
> 
> diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
> new file mode 100644
> index 0000000..2133a36
> --- /dev/null
> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
> @@ -0,0 +1,11 @@
> +upstream: OE-only

Hmm, do you think it is OE only. As written in my other message I
consider this an upstream patch, which has been committed already.

        upstream: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e
        comment: Patch is present in Linux kernel >= 2.6.25.

> +--- a/include/linux/Kbuild	2010-09-27 16:04:29.000000000 +0200
> ++++ b/include/linux/Kbuild	2010-09-27 15:59:06.000000000 +0200
> +@@ -61,6 +61,7 @@
> + header-y += elf.h
> + header-y += elf-em.h
> + header-y += fadvise.h
> ++header-y += falloc.h
> + header-y += fd.h
> + header-y += fdreg.h
> + header-y += fib_rules.h
> diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> index b90c478..e95299b 100644
> --- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> +++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
> @@ -2,10 +2,11 @@ require linux-libc-headers.inc
>  
>  INHIBIT_DEFAULT_DEPS = "1"
>  DEPENDS += "unifdef-native"
> -PR = "r5"
> +PR = "r6"
>  
>  SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
>             file://procinfo.h \
> +           file://export_falloc_h.patch \
>             file://unifdef.patch"
>  
>  S = "${WORKDIR}/linux-${PV}"


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH v3] linux-libc-headers_2.6.24: Add falloc.h to kernel exported headers

[Thilo Fromm]

Hello Paul,

>> This adds include/linux/falloc.h to the list of files exported by the kernel to the C library.
>> The include file is required for building e.g. a recent util-linux-ng against 2.6.24.
>>
>> Starting from 2.6.25 a similar patch has been accepted upstream (the mainline
>> kernel). For 2.6.24, however, falloc.h is not exported although it's present.
>>
[...]
>>   .../linux-libc-headers/files/export_falloc_h.patch |   11 +++++++++++
>> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
>> @@ -0,0 +1,11 @@
>> +upstream: OE-only
>
> Hmm, do you think it is OE only. As written in my other message I
> consider this an upstream patch, which has been committed already.
>
>          upstream: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e
>          comment: Patch is present in Linux kernel>= 2.6.25.

Technically, this upstreamed patch is not my patch. Upstream is way 
older, it's from a different author, etc. Plus it's included in 
successive kernel releases, but it's not in the version affected by my 
patch. From my point of view my patch is an OE-only hack because it 
back-ports to an older kernel version a different patch which originated 
from OE (?) a long time ago and then went mainline.

I'll of course change this to your suggestion if this is a problem. I 
did not do this yet so my patch won't get confused with the original one 
that went mainline.

Regards,
Thilo

-- 
Dipl.-Ing (FH) Thilo Fromm, MSc., Embedded Systems Developer
DResearch Digital Media Systems GmbH
Otto-Schmirgal-Str. 3, D-10319 Berlin, Germany
Tel: +49 (30) 515 932 228   mailto:t.fromm@dresearch.de
Fax: +49 (30) 515 932 77    http://www.dresearch.de
Amtsgericht: Berlin Charlottenburg, HRB:54412
Ust.-IDNr. DE169013825; WEEE Reg.-Nr. DE 85995642
Geschäftsführer: Dr. M. Weber, W. Mögle

Re: [PATCH v3] linux-libc-headers_2.6.24: Add falloc.h to kernel exported headers

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 2205 bytes --]

Dear Thilo,


Am Donnerstag, den 30.09.2010, 16:09 +0200 schrieb Thilo Fromm:

> >> This adds include/linux/falloc.h to the list of files exported by the kernel to the C library.
> >> The include file is required for building e.g. a recent util-linux-ng against 2.6.24.
> >>
> >> Starting from 2.6.25 a similar patch has been accepted upstream (the mainline
> >> kernel). For 2.6.24, however, falloc.h is not exported although it's present.
> >>
> [...]
> >>   .../linux-libc-headers/files/export_falloc_h.patch |   11 +++++++++++
> >> +++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
> >> @@ -0,0 +1,11 @@
> >> +upstream: OE-only
> >
> > Hmm, do you think it is OE only. As written in my other message I
> > consider this an upstream patch, which has been committed already.
> >
> >          upstream: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e
> >          comment: Patch is present in Linux kernel>= 2.6.25.
> 
> Technically, this upstreamed patch is not my patch. Upstream is way 
> older, it's from a different author, etc. Plus it's included in 
> successive kernel releases, but it's not in the version affected by my 
> patch. From my point of view my patch is an OE-only hack because it 
> back-ports to an older kernel version a different patch which originated 
> from OE (?) a long time ago and then went mainline.
> 
> I'll of course change this to your suggestion if this is a problem. I 
> did not do this yet so my patch won't get confused with the original one 
> that went mainline.

But as far as I can see, both patches do exactly the same thing. I do
not care about the authorship.

My main point is, that if someone is going through the patch files and
wonders, if that patch has to go upstream these comments help a lot.

I am not so long into OE, so others might clarify this.

The following would work too.

	upstream: OE-only
	comment: Same patch is present in Linux kernel ≥ 2.6.25 and was committed in <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e>.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

[PATCH v4] linux-libc-headers_2.6.24: Add falloc.h to kernel exported headers

[Thilo Fromm]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]

This adds include/linux/falloc.h to the list of files exported by the kernel to the C library.
The include file is required for building e.g. a recent util-linux-ng against 2.6.24.

Starting from 2.6.25 a similar patch has been accepted upstream (the mainline
kernel). For 2.6.24, however, falloc.h is not exported although it's present.

Signed-off-by: Thilo Fromm <t.fromm@dresearch.de>
---
 .../linux-libc-headers/files/export_falloc_h.patch |   13 +++++++++++++
 .../linux-libc-headers_2.6.24.bb                   |    3 ++-
 2 files changed, 15 insertions(+), 1 deletions(-)
 create mode 100644 recipes/linux-libc-headers/files/export_falloc_h.patch

diff --git a/recipes/linux-libc-headers/files/export_falloc_h.patch b/recipes/linux-libc-headers/files/export_falloc_h.patch
new file mode 100644
index 0000000..ba75e1f
--- /dev/null
+++ b/recipes/linux-libc-headers/files/export_falloc_h.patch
@@ -0,0 +1,13 @@
+upstream: OE-only
+comment: Same patch is present in Linux kernel ≥ 2.6.25 and was committed in <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=040922c04cf2c8ac70be2e88a8a9614ecdb41d2e>
+
+--- a/include/linux/Kbuild	2010-09-27 16:04:29.000000000 +0200
++++ b/include/linux/Kbuild	2010-09-27 15:59:06.000000000 +0200
+@@ -61,6 +61,7 @@
+ header-y += elf.h
+ header-y += elf-em.h
+ header-y += fadvise.h
++header-y += falloc.h
+ header-y += fd.h
+ header-y += fdreg.h
+ header-y += fib_rules.h
diff --git a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
index b90c478..e95299b 100644
--- a/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
+++ b/recipes/linux-libc-headers/linux-libc-headers_2.6.24.bb
@@ -2,10 +2,11 @@ require linux-libc-headers.inc
 
 INHIBIT_DEFAULT_DEPS = "1"
 DEPENDS += "unifdef-native"
-PR = "r5"
+PR = "r6"
 
 SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-${PV}.tar.bz2 \
            file://procinfo.h \
+           file://export_falloc_h.patch \
            file://unifdef.patch"
 
 S = "${WORKDIR}/linux-${PV}"
-- 
1.7.0.4