From: "H. Peter Anvin" <hpa@zytor.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Frederic Weisbecker" <fweisbec@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Márton Németh" <nm127@freemail.hu>,
"Arnd Bergmann" <arnd@arndb.de>, "Ian Kent" <raven@themaw.net>
Subject: Re: [PATCH 1/2] autofs: Only declare function when CONFIG_COMPAT is defined
Date: Thu, 30 Sep 2010 13:20:30 -0700 [thread overview]
Message-ID: <4CA4F10E.5060109@zytor.com> (raw)
In-Reply-To: <AANLkTinnRB-cpRrxymUQYMx0TjgkDkSbg=Euaq+Y16sE@mail.gmail.com>
On 09/30/2010 01:00 PM, Geert Uytterhoeven wrote:
>
> An alternative (and IMHO better) fix would be to move autofs_root_operations[]
> and autofs_root_inode_operations[] to the bottom of the file, and get rid of all
> the forward declarations.
>
This is a legacy piece of code (autofs3) which has been long since
obsolete anyway... it's one thing to do a minimal patch to keep it
alive, another to restructure crap when it's already overdue for removal.
-hpa
next prev parent reply other threads:[~2010-09-30 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 13:22 [PATCH 1/2] autofs: Only declare function when CONFIG_COMPAT is defined Frederic Weisbecker
2010-09-24 13:22 ` [PATCH 2/2] autofs4: " Frederic Weisbecker
2010-09-25 15:55 ` [PATCH 1/2] autofs: " Arnd Bergmann
2010-09-26 13:02 ` Frederic Weisbecker
2010-09-27 19:32 ` Andrew Morton
2010-10-04 8:26 ` Arnd Bergmann
2010-09-30 20:00 ` Geert Uytterhoeven
2010-09-30 20:20 ` H. Peter Anvin [this message]
2010-09-30 20:37 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA4F10E.5060109@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm127@freemail.hu \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.