All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@grandegger.com>
To: Masayuki Ohtake <masa-korg@dsn.okisemi.com>
Cc: andrew.chih.howe.khor@intel.com, qi.wang@intel.com,
	margie.foster@intel.com, netdev@vger.kernel.org,
	yong.y.wang@intel.com, linux-kernel@vger.kernel.org,
	socketcan-core@lists.berlios.de, kok.howg.ewe@intel.com,
	Christian Pellegrin <chripell@fsfe.org>,
	Tomoya MORINAGA <morinaga526@dsn.okisemi.com>,
	meego-dev@meego.com, "David S. Miller" <davem@davemloft.net>,
	joel.clark@intel.com, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35
Date: Fri, 01 Oct 2010 14:40:55 +0200	[thread overview]
Message-ID: <4CA5D6D7.3010608@grandegger.com> (raw)
In-Reply-To: <000401cb614f$c932c750$66f8800a@maildom.okisemi.com>

On 10/01/2010 12:02 PM, Masayuki Ohtake wrote:
> Hi Wolfgang Grandegger,
> 
> Thank you for your comments.
> 
> We will modify and re-post ASAP.
> 
> I have a comment about below.
>> In this driver you are using just *one* RX object. This means that the
>> CPU must handle new messages as quickly as possible otherwise message
>> losses will happen, right?. For sure, this will not make user's happy.
>> Any chance to use more RX objects in FIFO mode?
> 
> In case implementing with FIFO mode,
> received packets may be our of order.

Hm, FIFO means "First in First out"! It might be tricky to implement,
though.

> Because our CAN register access is slow.
> 
> I am confirming our CAN HW spec and the possibility of our-of-order.

I don't understand?

Wolfgang.


WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Masayuki Ohtake <masa-korg-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>
Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	margie.foster-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
	kok.howg.ewe-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	joel.clark-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	Tomoya MORINAGA
	<morinaga526-ECg8zkTtlr0C6LszWs/t0g@public.gmane.org>,
	meego-dev-WXzIur8shnEAvxtiuMwx3w@public.gmane.org,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	Christian Pellegrin <chripell-VaTbYqLCNhc@public.gmane.org>,
	Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35
Date: Fri, 01 Oct 2010 14:40:55 +0200	[thread overview]
Message-ID: <4CA5D6D7.3010608@grandegger.com> (raw)
In-Reply-To: <000401cb614f$c932c750$66f8800a-a06+6cuVnkTSQfdrb5gaxUEOCMrvLtNR@public.gmane.org>

On 10/01/2010 12:02 PM, Masayuki Ohtake wrote:
> Hi Wolfgang Grandegger,
> 
> Thank you for your comments.
> 
> We will modify and re-post ASAP.
> 
> I have a comment about below.
>> In this driver you are using just *one* RX object. This means that the
>> CPU must handle new messages as quickly as possible otherwise message
>> losses will happen, right?. For sure, this will not make user's happy.
>> Any chance to use more RX objects in FIFO mode?
> 
> In case implementing with FIFO mode,
> received packets may be our of order.

Hm, FIFO means "First in First out"! It might be tricky to implement,
though.

> Because our CAN register access is slow.
> 
> I am confirming our CAN HW spec and the possibility of our-of-order.

I don't understand?

Wolfgang.

  reply	other threads:[~2010-10-01 12:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24 10:24 [MeeGo-Dev][PATCH v3] Topcliff: Update PCH_CAN driver to 2.6.35 Masayuki Ohtak
2010-09-27  8:38 ` Wolfgang Grandegger
2010-09-27  8:38   ` Wolfgang Grandegger
2010-09-30  9:10 ` Wolfgang Grandegger
2010-09-30  9:10   ` Wolfgang Grandegger
2010-09-30 18:50   ` David Miller
2010-09-30 18:50     ` David Miller
2010-10-01 10:02   ` Masayuki Ohtake
2010-10-01 10:02     ` Masayuki Ohtake
2010-10-01 12:40     ` Wolfgang Grandegger [this message]
2010-10-01 12:40       ` Wolfgang Grandegger
2010-10-05 10:21       ` Masayuki Ohtake
2010-10-05 10:21         ` Masayuki Ohtake
2010-10-05 11:08         ` Marc Kleine-Budde
2010-10-05 12:09           ` Masayuki Ohtake
2010-10-05 12:09             ` Masayuki Ohtake
2010-10-05 18:45             ` David Miller
2010-10-05 18:45               ` David Miller
2010-10-06  3:07               ` Masayuki Ohtake
2010-10-06  3:07                 ` Masayuki Ohtake
2010-10-06  3:09                 ` David Miller
2010-10-06  3:09                   ` David Miller
2010-10-06  9:12                   ` Wolfgang Grandegger
2010-10-06  9:12                     ` Wolfgang Grandegger
2010-10-12  7:09                     ` Masayuki Ohtake
2010-10-12  7:09                       ` Masayuki Ohtake
2010-10-12  7:42                       ` Wolfgang Grandegger
2010-10-12  7:42                         ` Wolfgang Grandegger
2010-10-12  7:56                       ` Marc Kleine-Budde
2010-10-12  7:56                         ` Marc Kleine-Budde
2010-10-13  4:23                         ` Masayuki Ohtake
2010-10-13  4:23                           ` Masayuki Ohtake
2010-10-13  7:38                           ` Marc Kleine-Budde
2010-10-13  7:38                             ` Marc Kleine-Budde
2010-10-13 10:09   ` Masayuki Ohtake
2010-10-13 10:09     ` Masayuki Ohtake
2010-10-13 11:08     ` Wolfgang Grandegger
2010-10-13 11:08       ` Wolfgang Grandegger
2010-10-13 12:05       ` Masayuki Ohtake
2010-10-13 12:05         ` Masayuki Ohtake
  -- strict thread matches above, loose matches on Subject: below --
2010-09-24 10:24 Masayuki Ohtak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA5D6D7.3010608@grandegger.com \
    --to=wg@grandegger.com \
    --cc=andrew.chih.howe.khor@intel.com \
    --cc=chripell@fsfe.org \
    --cc=davem@davemloft.net \
    --cc=joel.clark@intel.com \
    --cc=kok.howg.ewe@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=margie.foster@intel.com \
    --cc=masa-korg@dsn.okisemi.com \
    --cc=meego-dev@meego.com \
    --cc=morinaga526@dsn.okisemi.com \
    --cc=netdev@vger.kernel.org \
    --cc=qi.wang@intel.com \
    --cc=sameo@linux.intel.com \
    --cc=socketcan-core@lists.berlios.de \
    --cc=yong.y.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.